tests: (in attempt to) fix 00596_limit_on_expanded_ast flakiness#91097
Merged
azat merged 2 commits intoClickHouse:masterfrom Nov 28, 2025
Merged
tests: (in attempt to) fix 00596_limit_on_expanded_ast flakiness#91097azat merged 2 commits intoClickHouse:masterfrom
azat merged 2 commits intoClickHouse:masterfrom
Conversation
Contributor
|
Workflow [PR], commit [4c04b16] Summary: ❌
|
clickhouse-gh
bot
added
the
pr-not-for-changelog
Looks like it was always slow [1] [1]: https://play.clickhouse.com/play?user=play#U0VMRUNUIGNoZWNrX3N0YXJ0X3RpbWUsIGNoZWNrX25hbWUsIGluc3RhbmNlX3R5cGUsIHRlc3RfbmFtZSwgdGVzdF9zdGF0dXMsIHRlc3RfZHVyYXRpb25fbXMsIHJlcG9ydF91cmwKRlJPTSBjaGVja3MKV0hFUkUgY2hlY2tfc3RhcnRfdGltZSA+PSBub3coKSAtIElOVEVSVkFMIDI0IGRheQogICAgQU5EIChoZWFkX3JlZiA9ICdtYXN0ZXInIEFORCBzdGFydHNXaXRoKGhlYWRfcmVwbywgJ0NsaWNrSG91c2UvJykpCiAgICAvL0FORCB0ZXN0X3N0YXR1cyAhPSAnU0tJUFBFRCcKICAgIC8vQU5EICh0ZXN0X3N0YXR1cyBMSUtFICdGJScgT1IgdGVzdF9zdGF0dXMgTElLRSAnRSUnKSAKICAgIC8vQU5EIGNoZWNrX3N0YXR1cyAhPSAnc3VjY2VzcycKICAgIEFORCBwb3NpdGlvbih0ZXN0X25hbWUsICcwMDU5Nl9saW1pdF9vbl9leHBhbmRlZF9hc3QnKSA+IDAKICAgIC8vYW5kIGNoZWNrX25hbWUgPSAnU3RhdGVsZXNzIHRlc3RzIChhbWRfbXNhbiwgcGFyYWxsZWwpJwogICAgYW5kIGNoZWNrX25hbWUgbGlrZSAnJWFtZF9tc2FuJScKT1JERVIgQlkgY2hlY2tfc3RhcnRfdGltZQ== And the reason is started to fail more frequently is targeted check. As for why it started to fail in `Stateless tests (amd_msan, parallel)`, maybe because after the job got merged (before it was splitted into 2 jobs) more tests was running in parallel, which can affect this test duration.
azat
force-pushed
the
tests/00596_limit_on_expanded_ast
branch
from
f69bdef to
2183613
Compare
Member
Author
|
Now targeted check is OK - https://s3.amazonaws.com/clickhouse-test-reports/json.html?PR=91097&sha=latest&name_0=PR&name_1=Stateless+tests+%28arm_asan%2C+targeted%29 And the test duration is ~5min, before it may exceed 10min |
hanfei1991
approved these changes
Nov 28, 2025
Merged
via the queue into
ClickHouse:master
with commit Nov 28, 2025
c0c188e
128 of 130 checks passed
robot-ch-test-poll1
added
the
pr-synced-to-cloud
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like it was always slow 1
And the reason is started to fail more frequently is targeted check.
As for why it started to fail in
Stateless tests (amd_msan, parallel), maybe because after the job got merged (before it was splitted into 2 jobs) more tests was running in parallel, which can affect this test duration.Changelog category (leave one):
Fixes: #90721