Test: Fix thread leaks and unsafe DB drops in Replicated database tests #90338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… integration tests - Stopped destroying system database 'default' (was breaking other tests) - Fixed thread leaks that could hang the entire test suite forever - Guaranteed thread cleanup with 'finally' blocks - All tests still pass, only stability improvements No server logic changed.
|
|
Algunenano
added
the
can be tested
clickhouse-gh
bot
added
the
pr-not-for-changelog
Algunenano
reviewed
Nov 19, 2025
Member
Algunenano
left a comment
Algunenano
left a comment
There was a problem hiding this comment.
Please don't merge master unnecessarily. Tests were failing correctly
Co-authored-by: Raúl Marín <[email protected]>
Co-authored-by: Raúl Marín <[email protected]>
Algunenano
reviewed
Nov 19, 2025
Algunenano
approved these changes
Nov 20, 2025
Member
Algunenano
left a comment
Algunenano
left a comment
There was a problem hiding this comment.
Nice job. Thanks a lot for improving the tests!
robot-clickhouse-ci-2
added
the
pr-synced-to-cloud
Contributor
|
Can you please avoid wording 'critical' etc. for test adjustments? Bad test is the issue for CI/CD, but nothing critical for the product itself. |
pareshjoshij
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Details
Fixes #90337
This PR fixes critical reliability issues and logic bugs in
tests/integration/test_database_replicated/test.pythat were causing test flakiness, potential hangs, and environment corruption.Key Changes
Fixed Thread Leaks / Race Conditions:
test_force_synchronous_settings, background threads (start_merges_threadandselect_thread) were joined after assertions. If an assertion failed, the threads were never joined and continued running in the background.ALTER TABLE) during subsequent tests, causing unpredictable failures and race conditions elsewhere in the suite.try...finallyblocks to guarantee cleanup regardless of test outcome.Prevented Destruction of
defaultDatabase:test_mv_false_cyclic_dependencywas executingDROP DATABASE default.test_cyclic_db(unique identifier) to ensure isolation.Stability Improvements:
Motivation
These changes are purely test-logic fixes. No server code is modified. The goal is to reduce CI flakiness and ensure that a failure in one test does not cascade into crashes in the rest of the suite.
Testing
Checklist