Skip to content

Yet another fix to enable shared snapshot#89795

Merged
bharatnc merged 2 commits intoClickHouse:masterfrom
amosbird:enable_shared_storage_snapshot_in_query_fix2
Nov 15, 2025
Merged

Yet another fix to enable shared snapshot#89795
bharatnc merged 2 commits intoClickHouse:masterfrom
amosbird:enable_shared_storage_snapshot_in_query_fix2

Conversation

@amosbird
Copy link
Copy Markdown
Collaborator

@amosbird amosbird commented Nov 10, 2025 •
edited by clickhouse-gh bot
Loading

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

This is for #82634 . It's interesting that ThreadGroup::query_context might not be a QueryContext

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Details

Additional fix related to PR #82634. Addresses an issue where ThreadGroup::query_context might not be a QueryContext as expected.

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Nov 10, 2025 •
edited
Loading

Workflow [PR], commit [57c2c69]

Summary: ❌

job_name test_name status info comment
Stateless tests (amd_tsan, s3 storage, parallel) failure
03652_memory_usage_headers FAIL cidb
Integration tests (amd_tsan, 1/6) failure
test_storage_s3_queue/test_parallel_inserts.py::test_parallel_inserts_with_failures[1] FAIL cidb, flaky
BuzzHouse (amd_debug) failure
Buzzing result failure cidb

@amosbird amosbird mentioned this pull request Nov 10, 2025
Merged
@clickhouse-gh clickhouse-gh bot added the pr-not-for-changelog This PR should not be mentioned in the changelog label Nov 10, 2025
@bharatnc bharatnc self-assigned this Nov 10, 2025
@bharatnc
Copy link
Copy Markdown
Contributor

bharatnc commented Nov 14, 2025

It looks like the failing tests are not related, merged master into branch, will let tests run once more and then merge.

@bharatnc
Copy link
Copy Markdown
Contributor

bharatnc commented Nov 15, 2025

Test failures don't look related:

@bharatnc bharatnc added this pull request to the merge queue Nov 15, 2025
Merged via the queue into ClickHouse:master with commit a55692c Nov 15, 2025
127 of 130 checks passed
@robot-clickhouse robot-clickhouse added the pr-synced-to-cloud The PR is synced to the cloud repo label Nov 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bharatnc bharatnc bharatnc approved these changes

Assignees

@bharatnc bharatnc

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@amosbird @bharatnc @robot-clickhouse