Skip to content

Fixed error in JSONEachRow when data is in array.#8958

Merged
tavplubix merged 5 commits intomasterfrom
json-each-row-array-fix
Feb 7, 2020
Merged

Fixed error in JSONEachRow when data is in array.#8958
tavplubix merged 5 commits intomasterfrom
json-each-row-array-fix

Conversation

@alexey-milovidov
Copy link
Copy Markdown
Member

Changelog category (leave one):

  • Bug Fix

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Do not include in changelog because the bug is not in release. This fixes #8948

@alexey-milovidov alexey-milovidov mentioned this pull request Feb 6, 2020
16 tasks
@tavplubix tavplubix added the pr-bugfix Pull request with bugfix, not backported by default label Feb 7, 2020
Copy link
Copy Markdown
Member

@nikitamikhaylov nikitamikhaylov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

++in.position();
skipWhitespaceIfAny(in);
}
if (!in.eof())
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary condition how I think.

@tavplubix tavplubix merged commit c6a8e4d into master Feb 7, 2020
@tavplubix tavplubix deleted the json-each-row-array-fix branch March 2, 2020 15:16
@KochetovNicolai
Copy link
Copy Markdown
Member

Conflicts with 20.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-bugfix Pull request with bugfix, not backported by default

Projects

None yet

Development

Successfully merging this pull request may close these issues.

square brackets in JSONEachRowFormat DB::Exception: Unexpected end of data

5 participants