Fix potential heap-use-after-free in projections analysis after #72102#89139
Merged
KochetovNicolai merged 1 commit intomasterfrom Nov 4, 2025
Merged
Conversation
KochetovNicolai
added
pr-must-backport
Contributor
clickhouse-gh
bot
added
the
pr-not-for-changelog
nikitamikhaylov
approved these changes
Oct 31, 2025
Member
nikitamikhaylov
left a comment
nikitamikhaylov
left a comment
There was a problem hiding this comment.
The changes appear right and logical, but I believe the test failures are related.
KochetovNicolai
deleted the
fix-potential-use-after-free-in-projection-analysis
branch
robot-ch-test-poll4
added
the
pr-synced-to-cloud
robot-clickhouse-ci-1
added
pr-backports-created-cloud
robot-clickhouse
added a commit
that referenced
this pull request
Nov 4, 2025
…ions analysis after #72102
robot-clickhouse
added a commit
that referenced
this pull request
Nov 4, 2025
…ions analysis after #72102
robot-clickhouse
added a commit
that referenced
this pull request
Nov 4, 2025
…ions analysis after #72102
robot-clickhouse
added a commit
that referenced
this pull request
Nov 4, 2025
…tions analysis after #72102
robot-ch-test-poll3
added
the
pr-backports-created
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Details
The code in the projection analysis used a reference to PK without holding the ownership. This became possible after #72102, when unloading of PK became possible.
Reference:
ClickHouse/src/Storages/MergeTree/IMergeTreeDataPart.cpp
Line 449 in f97cad2
Example of msan report: https://pastila.clickhouse.com/?001f9e74/a89113af1320e10120962200f4b3cc95#frgk+agY1FZ9YRQTl9ZIsw==