Fix skip indexes on data read with patch parts#88702
Closed
CurtizJ wants to merge 2 commits intoClickHouse:masterfrom
Closed
Fix skip indexes on data read with patch parts#88702CurtizJ wants to merge 2 commits intoClickHouse:masterfrom
CurtizJ wants to merge 2 commits intoClickHouse:masterfrom
Conversation
Contributor
|
Workflow [PR], commit [26f6a4f] Summary: ❌
|
clickhouse-gh
bot
added
the
pr-bugfix
rschu1ze
added
the
pr-must-backport
alexey-milovidov
added a commit
that referenced
this pull request
Mar 16, 2026
Continuation of #88702 - rebased on current master and fixed tests. The changes: - Extract `canUseIndex`/`canUseMergedIndex` as static methods on `MergeTreeDataSelectExecutor` so they can be reused in multiple places. - Add `canUseIndex` checks in `MergeTreeSkipIndexReader::read` to skip indexes that depend on columns being updated on the fly by lightweight updates. - Add `canUseIndex` check in `collectTextIndexReadInfos` to prevent direct reading from text index when the indexed column is updated. - Fix `MergeTreeReadersChain` to only read and apply patches at the step that actually has columns needing patches, not always at step 0. - Fix `addPatchPartsColumns` to find the correct first step with patches instead of assuming it is always the first prewhere step. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
Member
alexey-milovidov
added a commit
that referenced
this pull request
Mar 26, 2026
Continuation of #88702 - rebased on current master and fixed tests. The changes: - Extract `canUseIndex`/`canUseMergedIndex` as static methods on `MergeTreeDataSelectExecutor` so they can be reused in multiple places. - Add `canUseIndex` checks in `MergeTreeSkipIndexReader::read` to skip indexes that depend on columns being updated on the fly by lightweight updates. - Add `canUseIndex` check in `collectTextIndexReadInfos` to prevent direct reading from text index when the indexed column is updated. - Fix `MergeTreeReadersChain` to only read and apply patches at the step that actually has columns needing patches, not always at step 0. - Fix `addPatchPartsColumns` to find the correct first step with patches instead of assuming it is always the first prewhere step. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
Fixed usage of skip indexes on data read (with enabled setting
use_skip_indexes_on_data_read) and existing patch parts created by lightweight updates.