Revert "Enable skip index usage during read by default"#88638
Merged
Revert "Enable skip index usage during read by default"#88638
Conversation
This reverts commit ab56fb3.
Contributor
|
Workflow [PR], commit [7b4a68f] Summary: ❌
|
clickhouse-gh
bot
added
the
pr-not-for-changelog
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
shankar-iyer
approved these changes
Oct 16, 2025
This comment was marked as resolved.
This comment was marked as resolved.
shankar-iyer
approved these changes
Oct 21, 2025
Member
Author
|
Stateless tests (amd_binary, ParallelReplicas, s3 storage, parallel)
|
robot-ch-test-poll3
added
the
pr-synced-to-cloud
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#87368 enabled setting
use_skip_indexes_on_data_read. This led to the discovery of certain usability issues withEXPLAIN PLAN(#88467). These are addressed by #88504, however more functional problems popped up:use_skip_indexes_on_data_readcause wrong results EDIT: fixed by Fix skip indexes on data read with patch parts #88702use_skip_indexes_on_data_readcause wrong results EDIT: fixed by Fix reading from text index with query condition cache #88660max_rows_to_readandread_overflow_mode = throwcould fail : Fixed by Fix explain indexes with use_skip_indexes_on_data_read + use_query_condition_cache #88504use_skip_indexes_on_data_read= 1.These failures existed already in the original PR but were masked by setting
use_skip_indexes_on_data_read = 0in affected tests.This PR rolls back the setting enablement #87368 until these problems are fixed properly.
Changelog category (leave one):