Skip to content

Allow data in square brackets in JSONEachRowFormat.#8860

Merged
alexey-milovidov merged 4 commits intoClickHouse:masterfrom
Avogar:json_each_row
Jan 31, 2020
Merged

Allow data in square brackets in JSONEachRowFormat.#8860
alexey-milovidov merged 4 commits intoClickHouse:masterfrom
Avogar:json_each_row

Conversation

@Avogar
Copy link
Copy Markdown
Member

@Avogar Avogar commented Jan 27, 2020 •
edited by alexey-milovidov
Loading

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category (leave one):

  • New Feature

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
JSONEachRowFormat: support special case when objects enclosed in array. Here is an example:

air :) INSERT INTO students FORMAT JSONEachRow [{"id": 1, "name": "name1" }, {"id" : 2, "name": "name2"}]

INSERT INTO students FORMAT JSONEachRow

Ok.

2 rows in set. Elapsed: 0.015 sec.

@Avogar Avogar mentioned this pull request Jan 27, 2020
Closed
alexey-milovidov
alexey-milovidov requested changes Jan 30, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@alexey-milovidov alexey-milovidov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok but please add functional test.
They are inside dbms/tests/queries.

@alexey-milovidov
Copy link
Copy Markdown
Member

alexey-milovidov commented Jan 31, 2020

Difference in perf test: unrelated.

@alexey-milovidov alexey-milovidov merged commit dedf513 into ClickHouse:master Jan 31, 2020
alexey-milovidov added a commit that referenced this pull request Jan 31, 2020
@alexey-milovidov
Minor modifications for #8860
26e328c
@den-crane
Copy link
Copy Markdown
Contributor

den-crane commented Jan 31, 2020

it fails on long sets [.....] #8948

@tavplubix tavplubix added the pr-feature Pull request with new product feature label Feb 7, 2020
@alexey-milovidov alexey-milovidov mentioned this pull request Jun 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexey-milovidov alexey-milovidov alexey-milovidov requested changes

Assignees

No one assigned

Labels

pr-feature Pull request with new product feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Avogar @alexey-milovidov @den-crane @tavplubix