Skip to content

Disable use_query_condition_cache and run all tests#88477

Closed
zlareb1 wants to merge 2 commits intoClickHouse:masterfrom
zlareb1:test/use_query_condition_cache
Closed

Disable use_query_condition_cache and run all tests#88477
zlareb1 wants to merge 2 commits intoClickHouse:masterfrom
zlareb1:test/use_query_condition_cache

Conversation

@zlareb1
Copy link
Copy Markdown
Member

@zlareb1 zlareb1 commented Oct 13, 2025

Disable use_query_condition_cache and execute all tests to verify if disabling this setting causes any issues, as it is now enabled by default now

Note - This PR is not going to be merged. This is just for experimentation

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

...

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Oct 13, 2025

Workflow [PR], commit [bd86e7f]

Summary:

job_name test_name status info comment
Integration tests (amd_asan, old analyzer, 5/6) failure
test_settings_profile/test.py::test_show_profiles FAIL cidb
Integration tests (amd_binary, 2/5) failure
test_trace_log_memory_context/test.py::test_memory_context_in_trace_log FAIL cidb
Integration tests (amd_binary, 5/5) failure
test_settings_profile/test.py::test_show_profiles FAIL cidb
Integration tests (arm_binary, distributed plan, 2/4) failure
test_settings_profile/test.py::test_show_profiles FAIL cidb
Integration tests (amd_tsan, 5/6) failure
test_settings_profile/test.py::test_show_profiles FAIL cidb

@clickhouse-gh clickhouse-gh bot added the pr-not-for-changelog This PR should not be mentioned in the changelog label Oct 13, 2025
@zlareb1
Copy link
Copy Markdown
Member Author

zlareb1 commented Oct 15, 2025

test_settings_profile/test.py::test_show_profiles is failing bcz the assert is too strict (and use_query_condition_cache is added in query response):
query_expected_response = [ "CREATE SETTINGS PROFILE default\n", ] > assert ( instance.query("SHOW CREATE SETTINGS PROFILE default") in query_expected_response )
So, should be fine to ignore this failure

@zlareb1
Copy link
Copy Markdown
Member Author

zlareb1 commented Oct 15, 2025

We can ignore test_trace_log_memory_context/test.py::test_memory_context_in_trace_log failure as well. It is failing at:

File: test_trace_log_memory_context/test.py:73 - in test_memory_context_in_trace_log
    assert get_trace_events(memory_context, "Max", trace_type) > 0
E   AssertionError: assert 0 > 0
E    +  where 0 = <function test_memory_context_in_trace_log.<locals>.get_trace_events at 0x7f4268af91b0>('Global', 'Max', 'MemoryPeak')
===== Captured stderr setup =====
Running tests in /home/ubuntu/actions-runner/_work/ClickHouse/ClickHouse/tests/integration/test_trace_log_memory_context/test.py
Running tests in /home/ubuntu/actions-runner/_work/ClickHouse/ClickHouse/tests/integration/test_trace_log_memory_context/test.py

I think Trace events not being generated should be fine & looks unrelated to use_query_condition_cache disabled.

@zlareb1 zlareb1 closed this Oct 15, 2025
@zlareb1 zlareb1 changed the title WIP: Disable use_query_condition_cache and run all tests Disable use_query_condition_cache and run all tests Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant