Disable use_query_condition_cache and run all tests#88477
Closed
zlareb1 wants to merge 2 commits intoClickHouse:masterfrom
Closed
Disable use_query_condition_cache and run all tests#88477zlareb1 wants to merge 2 commits intoClickHouse:masterfrom
zlareb1 wants to merge 2 commits intoClickHouse:masterfrom
Conversation
Contributor
|
Workflow [PR], commit [bd86e7f] Summary: ❌
|
a951e41 to
6b5dcaf
Compare
Member
Author
|
test_settings_profile/test.py::test_show_profiles is failing bcz the assert is too strict (and use_query_condition_cache is added in query response): |
Member
Author
|
We can ignore test_trace_log_memory_context/test.py::test_memory_context_in_trace_log failure as well. It is failing at: I think Trace events not being generated should be fine & looks unrelated to use_query_condition_cache disabled. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disable use_query_condition_cache and execute all tests to verify if disabling this setting causes any issues, as it is now enabled by default now
Note - This PR is not going to be merged. This is just for experimentation
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
...
Documentation entry for user-facing changes