Skip to content

PR: fix (disable) JOINs with ARRAY/CROSS JOIN on left side#88465

Merged
devcrafter merged 6 commits intomasterfrom
pr-fix-join-with-array-join
Oct 16, 2025
Merged

PR: fix (disable) JOINs with ARRAY/CROSS JOIN on left side#88465
devcrafter merged 6 commits intomasterfrom
pr-fix-join-with-array-join

Conversation

@devcrafter
Copy link
Copy Markdown
Member

@devcrafter devcrafter commented Oct 13, 2025 •
edited
Loading

Related to https://github.com/ClickHouse/clickhouse-private/issues/11670

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Oct 13, 2025 •
edited
Loading

Workflow [PR], commit [df3b91d]

Summary: ❌

job_name test_name status info comment
Integration tests (amd_binary, 2/5) failure
test_merge_tree_s3/test.py::test_merge_canceled_by_s3_errors[node-broken_s3_always_multi_part] FAIL cidb
Integration tests (amd_tsan, 1/6) failure
test_async_load_databases/test.py::test_materialized_views_cascaded_multiple FAIL cidb
test_async_load_databases/test.py::test_materialized_views_replicated FAIL cidb
Performance Comparison (amd_release, master_head, 1/3) failure
Configure failure

@clickhouse-gh clickhouse-gh bot added the pr-not-for-changelog This PR should not be mentioned in the changelog label Oct 13, 2025
@devcrafter devcrafter mentioned this pull request Oct 13, 2025
Merged
@PedroTadim
Copy link
Copy Markdown
Member

PedroTadim commented Oct 13, 2025

Can you add a test?

@devcrafter
Copy link
Copy Markdown
Member Author

devcrafter commented Oct 13, 2025

Can you add a test?

Tests excluded from tests/parallel_replicas_blacklist.txt should succeed. Before they have failed.

@serxa serxa self-assigned this Oct 13, 2025
@devcrafter devcrafter enabled auto-merge October 14, 2025 13:21
@devcrafter
Copy link
Copy Markdown
Member Author

devcrafter commented Oct 16, 2025 •
edited
Loading

Flaky test are not related - see cidb links in #88465 (comment)

@devcrafter devcrafter added this pull request to the merge queue Oct 16, 2025
Merged via the queue into master with commit 60cd276 Oct 16, 2025
119 of 123 checks passed
@devcrafter devcrafter deleted the pr-fix-join-with-array-join branch October 16, 2025 10:33
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-synced-to-cloud The PR is synced to the cloud repo label Oct 16, 2025
@alexey-milovidov alexey-milovidov mentioned this pull request Feb 8, 2026
Closed
alexey-milovidov added a commit that referenced this pull request Feb 8, 2026
@alexey-milovidov @claude
Add test for duplicate rows with JOIN + CROSS JOIN and parallel replicas
3c8c62a 
Regression test for #74337
Fixed by #88465

Co-Authored-By: Claude Opus 4.6 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serxa serxa serxa approved these changes

Assignees

@serxa serxa

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@devcrafter @PedroTadim @serxa @robot-clickhouse-ci-2