Fix rows_before_aggregation for aggregation in order#88117
Merged
yariks5s merged 1 commit intoClickHouse:masterfrom Oct 14, 2025
Merged
Fix rows_before_aggregation for aggregation in order#88117yariks5s merged 1 commit intoClickHouse:masterfrom
yariks5s merged 1 commit intoClickHouse:masterfrom
Conversation
yariks5s
added
the
can be tested
Contributor
|
Workflow [PR], commit [faf10fa] Summary: ❌
|
clickhouse-gh
bot
added
the
pr-not-for-changelog
Current implementation sets rows_before_aggregation to consumed chunk number of rows. In cases when in order aggregation block in limited, and transformation splits the chunk to process it in more than one iteration, the counter starts to double account input rows.
korowa
force-pushed
the
fix-gby-in-order-rc
branch
from
7651934 to
faf10fa
Compare
yariks5s
approved these changes
Oct 14, 2025
Member
yariks5s
left a comment
yariks5s
left a comment
There was a problem hiding this comment.
Looks good, looks like we can do the same with src_bytes, but we can do it later
Member
|
|
Merged
via the queue into
ClickHouse:master
with commit Oct 14, 2025
d134479
121 of 123 checks passed
robot-clickhouse-ci-1
added
the
pr-synced-to-cloud
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #87927
Current implementation sets rows_before_aggregation to consumed chunk number of rows. In cases when in order aggregation block in limited, and transformation splits the chunk to process it in more than one iteration, the counter starts to double account input rows.
Changelog category (leave one):