Skip to content

Rename searchAny/All --> hasAny/AllTokens (full-text search related)#88109

Merged
rschu1ze merged 7 commits intomasterfrom
rename-searchAnyAll
Oct 6, 2025
Merged

Rename searchAny/All --> hasAny/AllTokens (full-text search related)#88109
rschu1ze merged 7 commits intomasterfrom
rename-searchAnyAll

Conversation

@rschu1ze
Copy link
Copy Markdown
Member

@rschu1ze rschu1ze commented Oct 5, 2025

Changelog category (leave one):

  • Backward Incompatible Change

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Renamed functions searchAny and searchAll to hasAnyTokens and hasAllTokens for better consistency with existing function hasToken.

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Oct 5, 2025 •
edited
Loading

Workflow [PR], commit [14ba028]

Summary: ⏳

job_name test_name status info comment
Stress test (amd_ubsan) failure
Server died FAIL
Hung check failed, possible deadlock found (see hung_check.log) FAIL
Killed by signal (in clickhouse-server.log) FAIL
Fatal message in clickhouse-server.log (see fatal_messages.txt) FAIL
Killed by signal (output files) FAIL
Found signal in gdb.log FAIL

@clickhouse-gh clickhouse-gh bot added the pr-backward-incompatible Pull request with backwards incompatible changes label Oct 5, 2025
@rschu1ze

This comment was marked as resolved.

Sign in to view
@rschu1ze rschu1ze changed the title Rename searchAny/All --> hasAny/AllTokens Rename searchAny/All --> hasAny/AllTokens (full-text search related) Oct 5, 2025
@ahmadov ahmadov self-assigned this Oct 5, 2025
@rschu1ze rschu1ze force-pushed the rename-searchAnyAll branch from 0e07cf9 to 32045fa Compare October 5, 2025 20:23
@Ergus
Copy link
Copy Markdown
Member

Ergus commented Oct 5, 2025

Just to know because I had some WIP somehow related. With this change the new function hasTokenLike needs to be called hasLikeToken to follow a standard name convention right?

Ergus
Ergus approved these changes Oct 5, 2025
View reviewed changes
@rschu1ze rschu1ze mentioned this pull request Oct 6, 2025
Closed
@rschu1ze

This comment was marked as outdated.

Sign in to view
@rschu1ze
Copy link
Copy Markdown
Member Author

rschu1ze commented Oct 6, 2025

With this change the new function hasTokenLike needs to be called hasLikeToken to follow a standard name convention right?

I like hasTokenLike a bit better, but functions can have aliases, so we could have both.

@rschu1ze
Copy link
Copy Markdown
Member Author

rschu1ze commented Oct 6, 2025

Stress test (amd_ubsan)

  • Disk does not support WriteMode::Append

@rschu1ze rschu1ze added this pull request to the merge queue Oct 6, 2025
Merged via the queue into master with commit bf8d54c Oct 6, 2025
117 of 122 checks passed
@rschu1ze rschu1ze deleted the rename-searchAnyAll branch October 6, 2025 12:41
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-synced-to-cloud The PR is synced to the cloud repo label Oct 6, 2025
@Blargian Blargian mentioned this pull request Nov 13, 2025
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ergus Ergus Ergus approved these changes

@ahmadov ahmadov ahmadov approved these changes

Assignees

@ahmadov ahmadov

Labels

pr-backward-incompatible Pull request with backwards incompatible changes pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rschu1ze @Ergus @ahmadov @robot-clickhouse-ci-1