Clean up temp files generated in s3_plain_rewritable moving file transaction.#88006
Merged
tuanpach merged 2 commits intoClickHouse:masterfrom Oct 8, 2025
Merged
Clean up temp files generated in s3_plain_rewritable moving file transaction.#88006tuanpach merged 2 commits intoClickHouse:masterfrom
tuanpach merged 2 commits intoClickHouse:masterfrom
Conversation
…eMoveFileOperation when loading table metadata in DatabaseOnDisk
Contributor
jkartseva
reviewed
Oct 6, 2025
| { | ||
| { | ||
| auto tmp_path_from = path_to.string() + ".move_from." + getRandomASCIIString(16); | ||
| auto tmp_path_from = path_to.string() + "." + getRandomASCIIString(16) + ".tmp_move_from"; |
Member
There was a problem hiding this comment.
Do we care about leftover files with names in the old format, which will not be removed because they don't end with ".tmp_move_from" (or ".tmp_move_to")?
Member
Author
There was a problem hiding this comment.
The default database disk is local. This case has only occurred in the CI jobs, so I think we don't need to handle the old file name format.
robot-ch-test-poll1
added
the
pr-synced-to-cloud
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
Clean up temp files generated in
MetadataStorageFromPlainObjectStorageMoveFileOperationwhen loading table metadata inDatabaseOnDisk.When moving files, the logic generated some temporary files. In
DatabaseOnDisk, we should clean them during the table metadata loading.Re-enable remote_database_disk in integration tests with
is_local_server_asan_build.Closes #87656
Documentation entry for user-facing changes