Skip to content

tests: fix flakiness of test_keeper_memory_soft_limit (make it less fragile)#87951

Merged
azat merged 1 commit intoClickHouse:masterfrom
azat:tests/test_keeper_memory_soft_limit
Oct 1, 2025
Merged

tests: fix flakiness of test_keeper_memory_soft_limit (make it less fragile)#87951
azat merged 1 commit intoClickHouse:masterfrom
azat:tests/test_keeper_memory_soft_limit

Conversation

@azat
Copy link
Copy Markdown
Member

@azat azat commented Sep 30, 2025

Apparently it got broken after the peak has been fixed for total memory tracker 1, but, this test does not work for me locally (even before mentioned changes, including the whole PR) because my local build takes ~240MiB in RAM while on CI it is ~70. Plus there can be also difference in x86_64 and aarch64.

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Fixes: #87787

…ragile)

Apparently it got broken after the peak has been fixed for total memory
tracker [1], but, this test does not work for me locally (even before
mentioned changes, including the whole PR) because my local build takes
~240MiB in RAM while on CI it is ~70. Plus there can be also difference
in x86_64 and aarch64.

  [1]: ClickHouse@24e16b0
@azat azat requested a review from hanfei1991 September 30, 2025 20:18
@azat azat added the 🍃 green ci 🌿 Fixing flaky tests in CI label Sep 30, 2025
@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Sep 30, 2025

Workflow [PR], commit [e86a895]

Summary:

job_name test_name status info comment
Integration tests (arm_binary, distributed plan, 1/4) failure
test_trace_log_memory_context/test.py::test_memory_context_in_trace_log FAIL

@clickhouse-gh clickhouse-gh bot added the pr-not-for-changelog This PR should not be mentioned in the changelog label Sep 30, 2025
@hanfei1991 hanfei1991 self-assigned this Oct 1, 2025
@azat azat enabled auto-merge October 1, 2025 05:32
@azat azat added this pull request to the merge queue Oct 1, 2025
Merged via the queue into ClickHouse:master with commit 61d8c47 Oct 1, 2025
121 of 123 checks passed
@azat azat deleted the tests/test_keeper_memory_soft_limit branch October 1, 2025 05:40
@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-synced-to-cloud The PR is synced to the cloud repo label Oct 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🍃 green ci 🌿 Fixing flaky tests in CI pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test_keeper_memory_soft_limit is flaky

3 participants