Skip to content

Safer IObjectStorage::tryGetObjectMetadata() (ignore only object existence error)#87485

Merged
azat merged 1 commit intoClickHouse:masterfrom
azat:objectstorage-safer-API
Sep 26, 2025
Merged

Safer IObjectStorage::tryGetObjectMetadata() (ignore only object existence error)#87485
azat merged 1 commit intoClickHouse:masterfrom
azat:objectstorage-safer-API

Conversation

@azat
Copy link
Copy Markdown
Member

@azat azat commented Sep 23, 2025

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Safer IObjectStorage::tryGetObjectMetadata() (ignore only object existence error). Ignoring any errors leads to bugs - #87426

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Sep 23, 2025 •
edited
Loading

Workflow [PR], commit [94da831]

Summary: ❌

job_name test_name status info comment
Integration tests (amd_asan, old analyzer, 3/6) failure
test_ddl_alter_query/test.py::test_ddl_queue_hostname_change FAIL
Integration tests (arm_binary, distributed plan, 4/4) failure
test_scheduler_cpu_preemptive/test.py::test_independent_pools FAIL
Stress test (amd_msan) failure
Server died FAIL
Hung check failed, possible deadlock found (see hung_check.log) FAIL
Killed by signal (in clickhouse-server.log) FAIL
Fatal message in clickhouse-server.log (see fatal_messages.txt) FAIL
Killed by signal (output files) FAIL
Found signal in gdb.log FAIL

@azat azat mentioned this pull request Sep 23, 2025
Merged
@clickhouse-gh clickhouse-gh bot added the pr-not-for-changelog This PR should not be mentioned in the changelog label Sep 23, 2025
@divanik divanik self-assigned this Sep 23, 2025
@azat
Copy link
Copy Markdown
Member Author

azat commented Sep 24, 2025

CI:

@azat
Copy link
Copy Markdown
Member Author

azat commented Sep 25, 2025

@divanik PTAL

divanik
divanik reviewed Sep 25, 2025
View reviewed changes
@azat azat force-pushed the objectstorage-safer-API branch from 1f36120 to 94da831 Compare September 25, 2025 16:24
@azat azat requested a review from divanik September 25, 2025 16:25
@azat azat enabled auto-merge September 25, 2025 17:18
@azat
Copy link
Copy Markdown
Member Author

azat commented Sep 25, 2025

Integration tests (amd_asan, old analyzer, 3/6)

Integration tests (arm_binary, distributed plan, 4/4)

@azat azat added this pull request to the merge queue Sep 26, 2025
Merged via the queue into ClickHouse:master with commit 56c5a10 Sep 26, 2025
120 of 124 checks passed
@azat azat deleted the objectstorage-safer-API branch September 26, 2025 06:57
@robot-clickhouse robot-clickhouse added the pr-synced-to-cloud The PR is synced to the cloud repo label Sep 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@divanik divanik divanik approved these changes

Assignees

@divanik divanik

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@azat @divanik @robot-clickhouse