Cherry pick #87426 to 25.7: Ignore only not found errors for s3_plain_rewritable (and some other S3 code)#87453
Merged
robot-clickhouse merged 3 commits intobackport/25.7/87426from Sep 23, 2025
Conversation
…S3 code)
MergeTree code does call readFileIfExists() in some places. For
s3_plain_rewritable, however, existsFile() looks unsafe because it
ignores **all** errors from S3.
For example, you might get an error such as "Response status: 503, Slow Down"
from S3. In that case, with s3_slow_all_threads_after_retryable_error,
the number of retries is reduced to 1, which makes it possible to get
false from existsFile()
Example stacktrace:
DB::S3::(anonymous namespace)::tryGetObjectInfo()
DB::S3::getObjectInfo()
DB::S3ObjectStorage::tryGetObjectMetadata()
DB::MetadataStorageFromPlainObjectStorage::getObjectMetadataEntryWithCache()
DB::MetadataStorageFromPlainObjectStorage::getObjectMetadataEntryWithCache()
DB::MetadataStorageFromPlainRewritableObjectStorage::existsFile()
Ignore only not found errors for s3_plain_rewritable (and some other S3 code)
robot-clickhouse
added
pr-cherrypick
robot-clickhouse
merged commit df8bad4
into
backport/25.7/87426
110 of 118 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original pull-request #87426
Do not merge this PR manually
This pull-request is a first step of an automated backporting.
It contains changes similar to calling
git cherry-picklocally.If you intend to continue backporting the changes, then resolve all conflicts if any.
Otherwise, if you do not want to backport them, then just close this pull-request.
The check results does not matter at this step - you can safely ignore them.
Troubleshooting
If the conflicts were resolved in a wrong way
If this cherry-pick PR is completely screwed by a wrong conflicts resolution, and you want to recreate it:
pr-cherrypicklabel from the PRYou also need to check the Original pull-request for
pr-backports-createdlabel, and delete if it's presented thereThe PR source
The PR is created in the CI job