Skip to content

Fix "Too large size passed to allocator" UB in JOIN due to mixed const and non-const blocks#87231

Merged
azat merged 4 commits intoClickHouse:masterfrom
azat:squashing-convert-to-full-column
Sep 22, 2025
Merged

Fix "Too large size passed to allocator" UB in JOIN due to mixed const and non-const blocks#87231
azat merged 4 commits intoClickHouse:masterfrom
azat:squashing-convert-to-full-column

Conversation

@azat
Copy link
Copy Markdown
Member

@azat azat commented Sep 17, 2025

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Fix "Too large size passed to allocator" LOGICAL_ERROR in JOIN due to mixed const and non-const blocks

The first patch in the series fixes this LOGICAL_ERROR, second one removes explicit materialization from INSERT and update the test, the third removes explicit materialization from views.

Follow-up for: #72226 (cc @vdimir )
Partial revert of: #86230

azat added 3 commits September 17, 2025 13:37
@azat
Fix "Too large size passed to allocator" UB in JOIN due to mixed cons…
9fca082 
…t and non-const blocks

It is possible to get const and non-const block after JOIN, so let's
improve ClickHouse#72226 to convert column to full if the serilizations does not
match, and add a test.
@azat
Remove explicit materialization on INSERT since squashing does it
3acbbe7
@azat
Remove explicit materialization from views since squashing does it
9bd2b37
@azat azat requested a review from vdimir September 17, 2025 11:40
@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Sep 17, 2025 •
edited
Loading

Workflow [PR], commit [af996ed]

Summary: ❌

job_name test_name status info comment
Stateless tests (amd_binary, ParallelReplicas, s3 storage, parallel) failure
03580_s3queue_settings_store FAIL
Exception in test runner FAIL
Killed by signal (in clickhouse-server.log or clickhouse-server.err.log) FAIL
Fatal messages (in clickhouse-server.log or clickhouse-server.err.log) FAIL
Stress test (amd_msan) failure
Server died FAIL
Hung check failed, possible deadlock found (see hung_check.log) FAIL
Killed by signal (in clickhouse-server.log) FAIL
Fatal message in clickhouse-server.log (see fatal_messages.txt) FAIL
Killed by signal (output files) FAIL
Found signal in gdb.log FAIL

@clickhouse-gh clickhouse-gh bot added the pr-bugfix Pull request with bugfix, not backported by default label Sep 17, 2025
@azat azat added the pr-must-backport Pull request should be backported intentionally. Use this label with great care! label Sep 17, 2025
@vdimir vdimir self-assigned this Sep 22, 2025
@azat azat enabled auto-merge September 22, 2025 15:31
@azat
Copy link
Copy Markdown
Member Author

azat commented Sep 22, 2025

CI - https://github.com/ClickHouse/ClickHouse/issues?q=is%3Aissue%20state%3Aopen%20%22Invalid%20number%20of%20rows%20in%20Chunk%22

@azat azat added this pull request to the merge queue Sep 22, 2025
Merged via the queue into ClickHouse:master with commit 8917a68 Sep 22, 2025
120 of 123 checks passed
@azat azat deleted the squashing-convert-to-full-column branch September 22, 2025 20:25
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-synced-to-cloud The PR is synced to the cloud repo label Sep 22, 2025
@robot-ch-test-poll1 robot-ch-test-poll1 added pr-backports-created-cloud deprecated label, NOOP pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR labels Sep 22, 2025
This was referenced Sep 22, 2025
Closed
Merged
Merged
robot-clickhouse added a commit that referenced this pull request Sep 22, 2025
@robot-clickhouse
Merge pull request #87434 from ClickHouse/cherrypick/25.7/87231
2d0f8e9 
Cherry pick #87231 to 25.7: Fix "Too large size passed to allocator" UB in JOIN due to mixed const and non-const blocks
@robot-clickhouse robot-clickhouse mentioned this pull request Sep 22, 2025
Merged
robot-clickhouse added a commit that referenced this pull request Sep 22, 2025
@robot-clickhouse
Backport #87231 to 25.7: Fix "Too large size passed to allocator" UB …
c2b8a93 
…in JOIN due to mixed const and non-const blocks
@robot-clickhouse robot-clickhouse mentioned this pull request Sep 22, 2025
Merged
robot-clickhouse added a commit that referenced this pull request Sep 22, 2025
@robot-clickhouse
Merge pull request #87436 from ClickHouse/cherrypick/25.8/87231
783ae6e 
Cherry pick #87231 to 25.8: Fix "Too large size passed to allocator" UB in JOIN due to mixed const and non-const blocks
robot-clickhouse added a commit that referenced this pull request Sep 22, 2025
@robot-clickhouse
Backport #87231 to 25.8: Fix "Too large size passed to allocator" UB …
752d9a9 
…in JOIN due to mixed const and non-const blocks
This was referenced Sep 22, 2025
Merged
Merged
robot-clickhouse added a commit that referenced this pull request Sep 22, 2025
@robot-clickhouse
Merge pull request #87438 from ClickHouse/cherrypick/25.9/87231
5a5c873 
Cherry pick #87231 to 25.9: Fix "Too large size passed to allocator" UB in JOIN due to mixed const and non-const blocks
robot-clickhouse added a commit that referenced this pull request Sep 22, 2025
@robot-clickhouse
Backport #87231 to 25.9: Fix "Too large size passed to allocator" UB …
009d5e9 
…in JOIN due to mixed const and non-const blocks
@robot-clickhouse robot-clickhouse mentioned this pull request Sep 22, 2025
Merged
clickhouse-gh bot added a commit that referenced this pull request Sep 22, 2025
@clickhouse-gh
Merge pull request #87435 from ClickHouse/backport/25.7/87231
7e68b82 
Backport #87231 to 25.7: Fix "Too large size passed to allocator" UB in JOIN due to mixed const and non-const blocks
clickhouse-gh bot added a commit that referenced this pull request Sep 22, 2025
@clickhouse-gh
Merge pull request #87437 from ClickHouse/backport/25.8/87231
319dadd 
Backport #87231 to 25.8: Fix "Too large size passed to allocator" UB in JOIN due to mixed const and non-const blocks
azat added a commit that referenced this pull request Sep 23, 2025
@azat
Merge pull request #87439 from ClickHouse/backport/25.9/87231
68bbf55 
Backport #87231 to 25.9: Fix "Too large size passed to allocator" UB in JOIN due to mixed const and non-const blocks
robot-clickhouse added a commit that referenced this pull request Sep 23, 2025
@robot-clickhouse
Merge pull request #87433 from ClickHouse/cherrypick/25.6/87231
3251a0e 
Cherry pick #87231 to 25.6: Fix "Too large size passed to allocator" UB in JOIN due to mixed const and non-const blocks
robot-clickhouse added a commit that referenced this pull request Sep 23, 2025
@robot-clickhouse
Backport #87231 to 25.6: Fix "Too large size passed to allocator" UB …
302a3b4 
…in JOIN due to mixed const and non-const blocks
@robot-clickhouse robot-clickhouse mentioned this pull request Sep 23, 2025
Merged
@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Sep 23, 2025
clickhouse-gh bot added a commit that referenced this pull request Sep 23, 2025
@clickhouse-gh
Merge pull request #87459 from ClickHouse/backport/25.6/87231
d6ceda6 
Backport #87231 to 25.6: Fix "Too large size passed to allocator" UB in JOIN due to mixed const and non-const blocks
azat added a commit that referenced this pull request Sep 23, 2025
@azat
Merge remote-tracking branch 'u/backport/25.9/87449' into cherrypick/…
cda044d 
…25.9/87449

* u/backport/25.9/87449:
  Backport #87426 to 25.9: Ignore only not found errors for s3_plain_rewritable (and some other S3 code)
  Backport #87231 to 25.9: Fix "Too large size passed to allocator" UB in JOIN due to mixed const and non-const blocks
  Backport #87198 to 25.9: Disable the setting by default
  Backport #87392 to 25.9: Fix EmbeddedRocksDB upgrade
  Backport #87140 to 25.9: fix: fix server level max temporary size limit
  Backport #87178 to 25.9: PR: fix LEFT/INNER ... RIGHT ... JOINS chain
  Update autogenerated version to 25.10.1.1 and contributors
@Fgrtue Fgrtue mentioned this pull request Feb 23, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vdimir vdimir vdimir approved these changes

Assignees

@vdimir vdimir

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud deprecated label, NOOP pr-bugfix Pull request with bugfix, not backported by default pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@azat @vdimir @robot-ch-test-poll1 @robot-ch-test-poll3 @robot-clickhouse-ci-2