Disable the setting s3_slow_all_threads_after_retryable_error by default#87198
Merged
nikitamikhaylov merged 4 commits intomasterfrom Sep 22, 2025
Merged
Disable the setting s3_slow_all_threads_after_retryable_error by default#87198nikitamikhaylov merged 4 commits intomasterfrom
s3_slow_all_threads_after_retryable_error by default#87198nikitamikhaylov merged 4 commits intomasterfrom
Conversation
Contributor
|
Workflow [PR], commit [5d3adac] Summary: ❌
|
clickhouse-gh
bot
added
the
pr-improvement
nikitamikhaylov
force-pushed
the
disable-backoff-by-default
branch
3 times, most recently
from
0d5bd14 to
8b225c7
Compare
SmitaRKulkarni
approved these changes
Sep 22, 2025
nikitamikhaylov
force-pushed
the
disable-backoff-by-default
branch
from
a3daf50 to
5d3adac
Compare
nikitamikhaylov
added
the
pr-must-backport
Member
Author
|
All test failures are |
robot-ch-test-poll1
added
the
pr-synced-to-cloud
robot-ch-test-poll2
added
pr-backports-created-cloud
This was referenced Sep 22, 2025
robot-ch-test-poll1
added a commit
that referenced
this pull request
Sep 22, 2025
Cherry pick #87198 to 25.6: Disable the setting by default
robot-clickhouse
added a commit
that referenced
this pull request
Sep 22, 2025
robot-ch-test-poll1
added a commit
that referenced
this pull request
Sep 22, 2025
Cherry pick #87198 to 25.8: Disable the setting by default
robot-clickhouse
added a commit
that referenced
this pull request
Sep 22, 2025
robot-ch-test-poll1
added a commit
that referenced
this pull request
Sep 22, 2025
Cherry pick #87198 to 25.9: Disable the setting by default
robot-clickhouse
added a commit
that referenced
this pull request
Sep 22, 2025
nikitamikhaylov
changed the title
s3_slow_all_threads_after_retryable_error by default
nikitamikhaylov
added a commit
that referenced
this pull request
Sep 22, 2025
Backport #87198 to 25.6: Disable the setting by default
nikitamikhaylov
added a commit
that referenced
this pull request
Sep 22, 2025
Backport #87198 to 25.8: Disable the setting by default
nikitamikhaylov
added a commit
that referenced
this pull request
Sep 22, 2025
Backport #87198 to 25.9: Disable the setting by default
robot-clickhouse
added
the
pr-backports-created
Member
|
You forgot to update the reference file for tests - https://s3.amazonaws.com/clickhouse-test-reports/json.html?PR=87439&sha=009d5e9107880bc49acd79582f01cc6c6e226fb0&name_0=BackportPR&name_1=Stateless%20tests%20%28amd_asan%2C%20distributed%20plan%2C%20parallel%2C%202%2F2%29 The problem is that this PR has been created before release, and so CI did not show this While backports has been merged w/o waiting for CI AFAICS which will show this problem Should be fixed by #87449 |
azat
added a commit
that referenced
this pull request
Sep 23, 2025
…25.9/87449 * u/backport/25.9/87449: Backport #87426 to 25.9: Ignore only not found errors for s3_plain_rewritable (and some other S3 code) Backport #87231 to 25.9: Fix "Too large size passed to allocator" UB in JOIN due to mixed const and non-const blocks Backport #87198 to 25.9: Disable the setting by default Backport #87392 to 25.9: Fix EmbeddedRocksDB upgrade Backport #87140 to 25.9: fix: fix server level max temporary size limit Backport #87178 to 25.9: PR: fix LEFT/INNER ... RIGHT ... JOINS chain Update autogenerated version to 25.10.1.1 and contributors
rschu1ze
reviewed
Sep 24, 2025
| {"use_skip_indexes_on_data_read", false, false, "New setting"}, | ||
| {"query_condition_cache_selectivity_threshold", 1.0, 1.0, "New setting."}, | ||
| {"s3_slow_all_threads_after_retryable_error", true, true, "Added an alias for setting `backup_slow_all_threads_after_retryable_s3_error`"}, | ||
| {"s3_slow_all_threads_after_retryable_error", false, false, "Added an alias for setting `backup_slow_all_threads_after_retryable_s3_error`"}, |
Member
There was a problem hiding this comment.
Is it correct that {"s3_slow_all_threads_after_retryable_error", false, false, [...] occurs 2x in the 25.10 section and the 25.9 section?
Member
Author
There was a problem hiding this comment.
Yes, also in 25.8 and 25.6
Member
There was a problem hiding this comment.
I think this was done because of backports.
For master, it will be cleaner to have each entry settings change just once in the version that first introduced it, here: 25.6.
Member
Author
There was a problem hiding this comment.
Unfortunately this is not the case and we need to do so not to break the upgrade check.
Member
There was a problem hiding this comment.
Fine with me of course, but it seems surprising.
There is a comment at the beginning of the file:
/// Note: please check if the key already exists to prevent duplicate entries.
The next guy reading this file is tempted to clean up duplicate entries.
@Algunenano Do you have thoughts?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
Disable
s3_slow_all_threads_after_retryable_errorby default.Documentation entry for user-facing changes