Skip to content

PR: fix LEFT/INNER ... RIGHT ... JOINS chain#87178

Merged
devcrafter merged 6 commits intomasterfrom
fix-pr-join-with-non-merge-tree
Sep 19, 2025
Merged

PR: fix LEFT/INNER ... RIGHT ... JOINS chain#87178
devcrafter merged 6 commits intomasterfrom
fix-pr-join-with-non-merge-tree

Conversation

@devcrafter
Copy link
Copy Markdown
Member

@devcrafter devcrafter commented Sep 16, 2025 •
edited
Loading

Closes #81144
Closes #63984

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Fix logical error with parallel replicas for queries with multiple JOINs, with RIGHT JOIN after LEFT/INNER JOIN in particular

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Sep 16, 2025 •
edited
Loading

Workflow [PR], commit [62921d2]

Summary: ❌

job_name test_name status info comment
Stress test (amd_ubsan) failure
Server died FAIL
Hung check failed, possible deadlock found (see hung_check.log) FAIL
Killed by signal (in clickhouse-server.log) FAIL
Fatal message in clickhouse-server.log (see fatal_messages.txt) FAIL
Killed by signal (output files) FAIL
Found signal in gdb.log FAIL
AST fuzzer (amd_debug) failure
Task failed: $?=1 FAIL
AST fuzzer (arm_asan) failure
Task failed: $?=1 FAIL
AST fuzzer (amd_tsan) failure
Task failed: $?=1 FAIL
AST fuzzer (amd_msan) failure
Task failed: $?=1 FAIL
AST fuzzer (amd_ubsan) failure
Task failed: $?=1 FAIL
BuzzHouse (amd_debug) failure
Task failed: $?=1 FAIL
BuzzHouse (arm_asan) failure
Task failed: $?=1 FAIL
BuzzHouse (amd_tsan) failure
Task failed: $?=1 FAIL
BuzzHouse (amd_msan) failure
Task failed: $?=1 FAIL
BuzzHouse (amd_ubsan) failure
Task failed: $?=1 FAIL

@clickhouse-gh clickhouse-gh bot added the pr-not-for-changelog This PR should not be mentioned in the changelog label Sep 16, 2025
@devcrafter devcrafter changed the title PR: try to fix n-way JOIN with non-merge tree storages PR: fix LEFT ... RIGHT ... JOINS chain Sep 18, 2025
@devcrafter devcrafter marked this pull request as ready for review September 18, 2025 13:22
@devcrafter
Copy link
Copy Markdown
Member Author

devcrafter commented Sep 18, 2025

https://s3.amazonaws.com/clickhouse-test-reports/json.html?PR=87178&sha=27a7f5a3c2bdb2d09d024bd071d7a410304c6faf&name_0=PR&name_1=Stateless+tests+%28amd_binary%2C+ParallelReplicas%2C+s3+storage%2C+parallel%29 - #85785

@vdimir vdimir self-assigned this Sep 19, 2025
vdimir
vdimir approved these changes Sep 19, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@vdimir vdimir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog category and entry can be:

  • Fix logical error with parallel replicas for queries with multiple JOINs using RIGHT JOIN.

@devcrafter devcrafter changed the title PR: fix LEFT ... RIGHT ... JOINS chain PR: fix LEFT/INNER ... RIGHT ... JOINS chain Sep 19, 2025
@clickhouse-gh clickhouse-gh bot added pr-bugfix Pull request with bugfix, not backported by default and removed pr-not-for-changelog This PR should not be mentioned in the changelog labels Sep 19, 2025
@devcrafter devcrafter added this pull request to the merge queue Sep 19, 2025
Merged via the queue into master with commit d1ad996 Sep 19, 2025
111 of 123 checks passed
@devcrafter devcrafter deleted the fix-pr-join-with-non-merge-tree branch September 19, 2025 15:32
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-synced-to-cloud The PR is synced to the cloud repo label Sep 19, 2025
@robot-ch-test-poll1 robot-ch-test-poll1 added pr-backports-created-cloud deprecated label, NOOP pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR labels Sep 19, 2025
@robot-ch-test-poll1 robot-ch-test-poll1 mentioned this pull request Sep 19, 2025
Merged
robot-ch-test-poll1 added a commit that referenced this pull request Sep 19, 2025
@robot-ch-test-poll1
Merge pull request #87349 from ClickHouse/cherrypick/25.9/87178
4f2d46d 
Cherry pick #87178 to 25.9: PR: fix LEFT/INNER ... RIGHT ... JOINS chain
robot-clickhouse added a commit that referenced this pull request Sep 19, 2025
@robot-clickhouse
Backport #87178 to 25.9: PR: fix LEFT/INNER ... RIGHT ... JOINS chain
ed67b9c
@robot-ch-test-poll1 robot-ch-test-poll1 mentioned this pull request Sep 19, 2025
Merged
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Sep 19, 2025
clickhouse-gh bot added a commit that referenced this pull request Sep 19, 2025
@clickhouse-gh
Merge pull request #87350 from ClickHouse/backport/25.9/87178
2284710 
Backport #87178 to 25.9: PR: fix LEFT/INNER ... RIGHT ... JOINS chain
azat added a commit that referenced this pull request Sep 23, 2025
@azat
Merge remote-tracking branch 'u/backport/25.9/87449' into cherrypick/…
cda044d 
…25.9/87449

* u/backport/25.9/87449:
  Backport #87426 to 25.9: Ignore only not found errors for s3_plain_rewritable (and some other S3 code)
  Backport #87231 to 25.9: Fix "Too large size passed to allocator" UB in JOIN due to mixed const and non-const blocks
  Backport #87198 to 25.9: Disable the setting by default
  Backport #87392 to 25.9: Fix EmbeddedRocksDB upgrade
  Backport #87140 to 25.9: fix: fix server level max temporary size limit
  Backport #87178 to 25.9: PR: fix LEFT/INNER ... RIGHT ... JOINS chain
  Update autogenerated version to 25.10.1.1 and contributors
@arthurpassos arthurpassos mentioned this pull request Oct 14, 2025
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vdimir vdimir vdimir approved these changes

Assignees

@vdimir vdimir

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud deprecated label, NOOP pr-bugfix Pull request with bugfix, not backported by default pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

5 participants

@devcrafter @vdimir @KochetovNicolai @robot-ch-test-poll1 @robot-clickhouse-ci-1