Initial commit to fix IParser::Pos.max_depth issue#8647
Merged
alexey-milovidov merged 3 commits intoClickHouse:masterfrom Jan 14, 2020
Merged
Initial commit to fix IParser::Pos.max_depth issue#8647alexey-milovidov merged 3 commits intoClickHouse:masterfrom
alexey-milovidov merged 3 commits intoClickHouse:masterfrom
Conversation
|
|
||
| size_t total_dictionaries = 0; | ||
| iterateMetadataFiles(context, [&file_names, &total_dictionaries, this](const String & file_name) | ||
| iterateMetadataFiles(context, [context, &file_names, &total_dictionaries, this](const String & file_name) |
Member
There was a problem hiding this comment.
Maybe &context to avoid copy?
Contributor
Author
There was a problem hiding this comment.
ok. I've never used C++ lambda functions.
alexey-milovidov
requested changes
Jan 14, 2020
Member
alexey-milovidov
left a comment
alexey-milovidov
left a comment
There was a problem hiding this comment.
Ok. And we also need a test (simple .sql test is enough, see dbms/tests/queries) to check that the setting works.
Contributor
Author
done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (up to few sentences, required except for Non-significant/Documentation categories):
New setting introduced: max_parser_depth. To control maximum stack size and allow long complex queries. This fixes #6681 and #7668.