Skip to content

Add ErrorCodes::TIMEOUT_EXCEEDED into the expected returning error code in thread_rename for 01150_ddl_guard_rwr#86321

Merged
tuanpach merged 1 commit intoClickHouse:masterfrom
tuanpach:fix-issue-85781
Aug 30, 2025
Merged

Add ErrorCodes::TIMEOUT_EXCEEDED into the expected returning error code in thread_rename for 01150_ddl_guard_rwr#86321
tuanpach merged 1 commit intoClickHouse:masterfrom
tuanpach:fix-issue-85781

Conversation

@tuanpach
Copy link
Copy Markdown
Member

@tuanpach tuanpach commented Aug 28, 2025

Changelog category (leave one):

  • CI Fix or Improvement (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

In this PR #85177, when acquiring the DB lock, we had retrying logic and threw ErrorCodes::TIMEOUT_EXCEEDED when it fails.

We need to expect this error in 01150_ddl_guard_rwr when renaming

Closes #85781

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

@tuanpach tuanpach added the can be tested Allows running workflows for external contributors label Aug 28, 2025
@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Aug 28, 2025 •
edited
Loading

Workflow [PR], commit [c4d3ab5]

Summary: ❌

job_name test_name status info comment
Stateless tests (amd_tsan, parallel, 1/2) failure
02790_async_queries_in_query_log FAIL
Stateless tests (amd_ubsan, parallel) failure
02177_issue_31009 FAIL
03244_skip_index_in_final_query_with_pk_rescan FAIL
Stress test (amd_msan) failure
Server died FAIL
Hung check failed, possible deadlock found (see hung_check.log) FAIL
Killed by signal (in clickhouse-server.log) FAIL
Fatal message in clickhouse-server.log (see fatal_messages.txt) FAIL
Killed by signal (output files) FAIL
Found signal in gdb.log FAIL

@clickhouse-gh clickhouse-gh bot added the pr-ci label Aug 28, 2025
@evillique evillique self-assigned this Aug 28, 2025
@tuanpach
Copy link
Copy Markdown
Member Author

tuanpach commented Aug 28, 2025

@tuanpach tuanpach enabled auto-merge August 28, 2025 05:55
@tuanpach tuanpach disabled auto-merge August 28, 2025 07:31
@tuanpach tuanpach enabled auto-merge August 30, 2025 00:27
@tuanpach tuanpach added this pull request to the merge queue Aug 30, 2025
Merged via the queue into ClickHouse:master with commit ef47530 Aug 30, 2025
120 of 122 checks passed
@tuanpach tuanpach deleted the fix-issue-85781 branch August 30, 2025 01:48
@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-synced-to-cloud The PR is synced to the cloud repo label Aug 30, 2025
@robot-ch-test-poll4 robot-ch-test-poll4 added pr-backports-created-cloud deprecated label, NOOP pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR labels Aug 30, 2025
@robot-ch-test-poll robot-ch-test-poll mentioned this pull request Aug 30, 2025
Merged
robot-ch-test-poll added a commit that referenced this pull request Aug 30, 2025
@robot-ch-test-poll
Merge pull request #86424 from ClickHouse/cherrypick/25.8/86321
e4b86fe 
Cherry pick #86321 to 25.8: Add ErrorCodes::TIMEOUT_EXCEEDED into the expected returning error code in thread_rename for 01150_ddl_guard_rwr
robot-clickhouse added a commit that referenced this pull request Aug 30, 2025
@robot-clickhouse
Backport #86321 to 25.8: Add ErrorCodes::TIMEOUT_EXCEEDED into the ex…
47b352f 
…pected returning error code in thread_rename for 01150_ddl_guard_rwr
@robot-ch-test-poll robot-ch-test-poll mentioned this pull request Aug 30, 2025
Merged
@robot-ch-test-poll robot-ch-test-poll added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Aug 30, 2025
clickhouse-gh bot added a commit that referenced this pull request Aug 30, 2025
@clickhouse-gh
Merge pull request #86425 from ClickHouse/backport/25.8/86321
1823f23 
Backport #86321 to 25.8: Add ErrorCodes::TIMEOUT_EXCEEDED into the expected returning error code in thread_rename for 01150_ddl_guard_rwr
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@evillique evillique evillique approved these changes

Assignees

@evillique evillique

Labels

can be tested Allows running workflows for external contributors pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud deprecated label, NOOP pr-ci pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR pr-synced-to-cloud The PR is synced to the cloud repo v25.8-must-backport

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

01150_ddl_guard_rwr is flaky

6 participants

@tuanpach @evillique @Algunenano @robot-ch-test-poll @robot-ch-test-poll2 @robot-ch-test-poll4