Disable use_skip_indexes_on_data_read by default#86273
Disable use_skip_indexes_on_data_read by default#86273CurtizJ merged 2 commits intoClickHouse:masterfrom
use_skip_indexes_on_data_read by default#86273Conversation
|
Workflow [PR], commit [0cd23dc] Summary: ❌
|
clickhouse-gh
bot
added
the
pr-not-for-changelog
amosbird
force-pushed
the
disable-apply-skip-index-on-reading
branch
from
c435af6 to
0cd23dc
Compare
792a16a
robot-ch-test-poll
added
the
pr-synced-to-cloud
|
This feature itself doesn’t have correctness issues, but it’s not strictly better in all aspects. For example, applying filters during the plan stage can sometimes produce a smaller and more efficient execution plan. Also, it may affect some use cases that rely on explain estimate. |
|
What are the next steps? Maybe enable in 25.10? |
I’m happy either way. I’ll go with your judgment on whether to enable it. |
Let's do it, this will also help to figure out edge cases. (Tales from a stupid: I actually ran ClickBench with |
|
FYI, clickbench is already run on every commit
…On Wed, 17 Sep 2025 at 04:33, Robert Schulze ***@***.***> wrote:
*rschu1ze* left a comment (ClickHouse/ClickHouse#86273)
<#86273 (comment)>
I’m happy either way. I’ll go with your judgment on whether to enable it.
Let's do it, this will also help to figure out edge cases.
(Tales from a stupid: I actually ran ClickBench with
use_skip_indexes_on_data_read enabled vs. disabled. There was no
difference and I realized that ClickBench doesn't define skip indexes :-) )
—
Reply to this email directly, view it on GitHub
<#86273 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AENYP4H2EVRRY44ZG6ZS4ET3TEMGJAVCNFSM6AAAAACE6GFFMCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTGMBRHEZTAMBQHA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
rschu1ze
changed the title
use_skip_indexes_on_data_read by default
--> #87368 |
5 participants
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
Disable
use_skip_indexes_on_data_readby default. #81526 is merged with this setting enabled to do more thorough testing. cc @CurtizJDocumentation entry for user-facing changes