Skip to content

Remove deprecated Object type#85718

Merged
nikitamikhaylov merged 29 commits intoClickHouse:masterfrom
Avogar:remove-deprecated-object
Nov 12, 2025
Merged

Remove deprecated Object type#85718
nikitamikhaylov merged 29 commits intoClickHouse:masterfrom
Avogar:remove-deprecated-object

Conversation

@Avogar
Copy link
Copy Markdown
Member

@Avogar Avogar commented Aug 15, 2025

Changelog category (leave one):

  • Backward Incompatible Change

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Remove deprecated Object type.

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Aug 15, 2025

Workflow [PR], commit [40643ae]

Summary:

job_name test_name status info comment
Stateless tests (arm_binary, sequential) failure
03141_fetches_errors_stress FAIL cidb, flaky

@clickhouse-gh clickhouse-gh bot added the pr-backward-incompatible Pull request with backwards incompatible changes label Aug 15, 2025
@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Aug 15, 2025

@ClickHouse/integrations-ecosystem please, take a look

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Sep 4, 2025

@ClickHouse/integrations team, please, take a look

@Avogar
Copy link
Copy Markdown
Member Author

Avogar commented Sep 8, 2025

@Blargian Docs check fails because we have references to the deprecated Object type. I didn't find those references in the ClickHouse repository, I suspect they are in the clickhouse-docs repository. Can you please take a look and delete those references?

@chernser
Copy link
Copy Markdown

Good day, @Avogar !

Object type seems used in AggregateFunction when Dynamically encoded and has tag 0x14 ( https://clickhouse.com/docs/sql-reference/data-types/data-types-binary-encoding#aggregate-function-parameter-binary-encoding).

Is tag 0x14 going to be reserved and not just removed so enumeration stays unchanged?
Do Object has a dynamic type tag (I've not found in the doc)? If so - tags enumeration will not shift, too?

Thanks!

@Avogar
Copy link
Copy Markdown
Member Author

Avogar commented Sep 30, 2025

Hi @chernser!

Object type seems used in AggregateFunction when Dynamically encoded and has tag 0x14 ( https://clickhouse.com/docs/sql-reference/data-types/data-types-binary-encoding#aggregate-function-parameter-binary-encoding).
Is tag 0x14 going to be reserved and not just removed so enumeration stays unchanged?

The Object you are referring to is not a deprecated Object ClickHouse data type, it's a simple field type in the code that can store map String -> Value:

DEFINE_FIELD_MAP(Object);

It won't be removed.

Do Object has a dynamic type tag (I've not found in the doc)? If so - tags enumeration will not shift, too?

It doesn't have it, deprecated Object type was not supported in binary types serialization because it was supposed to be removed:

case TypeIndex::ObjectDeprecated:
/// Object type will be deprecated and replaced by new implementation. No need to support it here.
throw Exception(ErrorCodes::UNSUPPORTED_METHOD, "Binary encoding of type Object is not supported");

@Avogar
Copy link
Copy Markdown
Member Author

Avogar commented Nov 7, 2025

Waiting for sync to finish

@nikitamikhaylov nikitamikhaylov added this pull request to the merge queue Nov 12, 2025
Merged via the queue into ClickHouse:master with commit 135e775 Nov 12, 2025
128 of 130 checks passed
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-synced-to-cloud The PR is synced to the cloud repo label Nov 12, 2025
@Avogar Avogar mentioned this pull request Dec 2, 2025
56 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-backward-incompatible Pull request with backwards incompatible changes pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants