Cherry pick #85440 to 24.8: Fix possible UB in case of MEMORY_LIMIT_EXCEEDED during String deserialization#85580
Merged
robot-ch-test-poll3 merged 5 commits intobackport/24.8/85440from Aug 15, 2025
Conversation
…alization Previously it was possible to leave `offsets` and `data` out of sync if `data.resize_exact` fails with `MEMORY_LIMIT_EXCEEDED`, which eventually will lead to various UBs (i.e. `SIZES_OF_COLUMNS_DOESNT_MATCH` and `LOGICAL_ERROR`)
W/o the fix it always fails, i.e.:
$ src/unit_tests_dbms --gtest_filter=StringSerialization.*
Note: Google Test filter = StringSerialization.*
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from StringSerialization
[ RUN ] StringSerialization.IncorrectStateAfterMemoryLimitExceeded
/src/ch/clickhouse/src/DataTypes/Serializations/tests/gtest_string_serialization.cpp:79: Failure
Expected equality of these values:
result.getDataAt(result.size() - 1)
Which is: ar\0foo
"foobar"
Which is: 0x555557ce25a3
[ FAILED ] StringSerialization.IncorrectStateAfterMemoryLimitExceeded (28 ms)
[----------] 1 test from StringSerialization (28 ms total)
[----------] Global test environment tear-down
[==========] 1 test from 1 test suite ran. (30 ms total)
[ PASSED ] 0 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] StringSerialization.IncorrectStateAfterMemoryLimitExceeded
1 FAILED TEST
Fix possible UB in case of MEMORY_LIMIT_EXCEEDED during String deserialization
robot-ch-test-poll4
added
pr-cherrypick
Contributor
|
Dear @azat, @alexey-milovidov, the PR is not updated for 1d0h0m21s. Please, either resolve the conflicts, or close it to finish the backport process of #85440 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original pull-request #85440
Do not merge this PR manually
This pull-request is a first step of an automated backporting.
It contains changes similar to calling
git cherry-picklocally.If you intend to continue backporting the changes, then resolve all conflicts if any.
Otherwise, if you do not want to backport them, then just close this pull-request.
The check results does not matter at this step - you can safely ignore them.
Troubleshooting
If the conflicts were resolved in a wrong way
If this cherry-pick PR is completely screwed by a wrong conflicts resolution, and you want to recreate it:
pr-cherrypicklabel from the PRYou also need to check the Original pull-request for
pr-backports-createdlabel, and delete if it's presented thereThe PR source
The PR is created in the CI job