Skip to content

aggregated zookeeper log#85102

Merged
mstetsyuk merged 64 commits intomasterfrom
lightweight-zookeeper-log
Sep 16, 2025
Merged

aggregated zookeeper log#85102
mstetsyuk merged 64 commits intomasterfrom
lightweight-zookeeper-log

Conversation

@mstetsyuk
Copy link
Copy Markdown
Member

@mstetsyuk mstetsyuk commented Aug 5, 2025 •
edited
Loading

Changelog category (leave one):

  • New Feature

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Adds a new system.aggregated_zookeeper_log table. The table contains statistics (e.g. number of operations, average latency, errors) of ZooKeeper operations grouped by session id, parent path and operation type, and periodically flushed to disk.

This table is meant to be used in production by default because, in contrast tosystem.zookeeper_log, it's much more lightweight.

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Aug 5, 2025 •
edited
Loading

Workflow [PR], commit [0f3298d]

Summary: ❌

job_name test_name status info comment
Integration tests (amd_asan, old analyzer, 1/6) failure
OOM in dmesg FAIL
test_polymorphic_parts/test.py::test_polymorphic_parts_basics[first_node1-second_node1] FAIL
test_storage_delta/test.py::test_writes_spark_compatibility FAIL
test_storage_delta/test.py::test_write_limits[True-False] FAIL
test_refreshable_mv_skip_old_temp_table_ddls/test.py::test_refreshable_mv_skip_old_temp_tables_ddls[1-True-False] FAIL
test_distributed_ddl_parallel/test.py::test_smoke_parallel_dict_reload FAIL
test_storage_delta/test.py::test_write_limits[True-True] FAIL
test_storage_delta/test.py::test_writes FAIL
test_refreshable_mv_skip_old_temp_table_ddls/test.py::test_refreshable_mv_skip_old_temp_tables_ddls[1-True-True] FAIL
Integration tests (amd_tsan, 4/6) failure
test_fetch_partition_with_outdated_parts/test.py::test_fetch_partition_with_outdated_parts FAIL
Finish Workflow failure
python3 ./ci/jobs/scripts/workflow_hooks/feature_docs.py failure

@clickhouse-gh clickhouse-gh bot added the pr-feature Pull request with new product feature label Aug 5, 2025
@mstetsyuk mstetsyuk marked this pull request as ready for review August 13, 2025 13:56
@antaljanosbenjamin antaljanosbenjamin self-assigned this Aug 13, 2025
@mstetsyuk mstetsyuk changed the title lightweight zookeeper log aggregated zookeeper log Aug 14, 2025
@mstetsyuk mstetsyuk marked this pull request as draft September 10, 2025 14:42
@mstetsyuk mstetsyuk marked this pull request as ready for review September 12, 2025 09:56
@mstetsyuk mstetsyuk added this pull request to the merge queue Sep 16, 2025
Merged via the queue into master with commit e73908b Sep 16, 2025
119 of 123 checks passed
@mstetsyuk mstetsyuk deleted the lightweight-zookeeper-log branch September 16, 2025 10:03
@robot-ch-test-poll robot-ch-test-poll added the pr-synced-to-cloud The PR is synced to the cloud repo label Sep 16, 2025
@Algunenano
Copy link
Copy Markdown
Member

Algunenano commented Sep 16, 2025

Please remember to always check any test failures before merging a PR. TSAN is unhappy and you ignored it: https://s3.amazonaws.com/clickhouse-test-reports/REFs/master/27381a24460ab1c622d14989fdeac9f0662db4e6//integration_tests_amd_tsan_1_6/integration_run_parallel_0.log

Reverting

@Algunenano Algunenano mentioned this pull request Sep 16, 2025
Merged
@mstetsyuk mstetsyuk mentioned this pull request Sep 16, 2025
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antaljanosbenjamin antaljanosbenjamin antaljanosbenjamin approved these changes

Assignees

@antaljanosbenjamin antaljanosbenjamin

Labels

pr-feature Pull request with new product feature pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mstetsyuk @Algunenano @antaljanosbenjamin @robot-ch-test-poll