try fix some predicate optimizer bug#8503
Merged
alexey-milovidov merged 9 commits intoClickHouse:masterfrom Jan 9, 2020
Merged
try fix some predicate optimizer bug#8503alexey-milovidov merged 9 commits intoClickHouse:masterfrom
alexey-milovidov merged 9 commits intoClickHouse:masterfrom
Conversation
zhang2014
force-pushed
the
fix/some_predicate_bug
branch
from
ab313fc to
932c3ff
Compare
zhang2014
force-pushed
the
fix/some_predicate_bug
branch
from
932c3ff to
6a5e3e2
Compare
Contributor
Author
|
@alexey-milovidov
|
zhang2014
force-pushed
the
fix/some_predicate_bug
branch
from
d06c1bf to
2179935
Compare
zhang2014
force-pushed
the
fix/some_predicate_bug
branch
from
9b4f93e to
0f147e3
Compare
Member
|
too many conflicts in 19.17. |
azat
added a commit
to azat/ClickHouse
that referenced
this pull request
Mar 14, 2024
…imizer_bugs The behaviour of GROUP BY const in analyzer is slightly different, it still preserves the const property from the subqueries, and that's why it simply do not execute filters after GROUP BY, but simply one time for the const. The initial bug was about predicate pushdown not about GROUP BY const, so I will update the test. I've also tested the initial bug with fiddle and the new test is idential: - 19.17 (without the fix) - https://fiddle.clickhouse.com/312a48f4-6a5b-411d-a4bb-4b1a757effaf - 20.2 (with the fix) - https://fiddle.clickhouse.com/4e1ad2e5-1c03-4ce7-9ac3-e878ccfae83a Refs: ClickHouse#8503 Refs: ClickHouse#5682 Signed-off-by: Azat Khuzhin <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category:
Changelog entry:
Fix some predicate optimizer wrong results
Detailed description:
fixed #3885 #5485 #5682 #6734 #6767 #7136 #5674 #4731 #4904 #7802