Added aggregate function aggThrow#8446
Merged
alexey-milovidov merged 7 commits intomasterfrom Dec 28, 2019
Merged
Conversation
alexey-milovidov
added
the
pr-build
alexey-milovidov
added
the
pr-bugfix
amosbird
reviewed
Dec 28, 2019
| catch (...) | ||
| { | ||
| agg_func.destroy(places[i]); | ||
| for (size_t j = 0; j < i; ++j) |
Collaborator
There was a problem hiding this comment.
Nice catch! I've also examined all sites of agg state construction and found that https://github.com/yandex/ClickHouse/blob/master/dbms/src/AggregateFunctions/AggregateFunctionResample.h#L102 needs a fix too
for (size_t i = 0; i < total; ++i)
{
try
{
nested_function->create(place + i * size_of_data);
}
catch (...)
{
for (size_t j = 0; j < i; ++j)
nested_function->destroy(place + j * size_of_data);
throw;
}
}
Member
Author
There was a problem hiding this comment.
Ok, I'll do it also.
Member
|
conflicts in 19.17 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (up to few sentences, required except for Non-significant/Documentation categories):
Fixed error in function
arrayReducethat may lead to "double free" and error in aggregate function combinatorResamplethat may lead to memory leak. Added aggregate functionaggThrow. This function can be used for testing purposes.