Skip to content

Fix crash during waiting for EndOfQuery in client after failed INSERT#83842

Merged
azat merged 1 commit intoClickHouse:masterfrom
azat:client-connection-crash-v2
Jul 21, 2025
Merged

Fix crash during waiting for EndOfQuery in client after failed INSERT#83842
azat merged 1 commit intoClickHouse:masterfrom
azat:client-connection-crash-v2

Conversation

@azat
Copy link
Copy Markdown
Member

@azat azat commented Jul 16, 2025

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Fix crash in client due to connection left in disconnected state after bad INSERT

Fixes: #83123 (comment) (cc @tavplubix )
Follow-up: #83253

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Jul 16, 2025 •
edited
Loading

Workflow [PR], commit [97e997f]

Summary: ❌

job_name test_name status info comment
Finish Workflow failure
python3 ./ci/jobs/scripts/workflow_hooks/new_tests_check.py failure

@clickhouse-gh clickhouse-gh bot added the pr-bugfix Pull request with bugfix, not backported by default label Jul 16, 2025
@azat azat added the 🍃 green ci 🌿 Fixing flaky tests in CI label Jul 21, 2025
@pamarcos pamarcos self-requested a review July 21, 2025 14:16
@pamarcos pamarcos self-assigned this Jul 21, 2025
@azat azat enabled auto-merge July 21, 2025 14:23
@azat
Copy link
Copy Markdown
Member Author

azat commented Jul 21, 2025 •
edited
Loading

Stateless tests (amd_binary, old analyzer, s3 storage, DatabaseReplicated, 1/2) — Failed: 0, Passed: 3895, Skipped: 215

  • 03164_parallel_replicas_range_filter_min_max - @maxknv interesting that report does not contains failure, I can find it only in raw logs

@azat azat added this pull request to the merge queue Jul 21, 2025
Merged via the queue into ClickHouse:master with commit ff4fc41 Jul 21, 2025
348 of 357 checks passed
@azat azat deleted the client-connection-crash-v2 branch July 21, 2025 14:40
@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-synced-to-cloud The PR is synced to the cloud repo label Jul 21, 2025
@maxknv
Copy link
Copy Markdown
Member

maxknv commented Jul 22, 2025

Stateless tests (amd_binary, old analyzer, s3 storage, DatabaseReplicated, 1/2) — Failed: 0, Passed: 3895, Skipped: 215

  • 03164_parallel_replicas_range_filter_min_max - @maxknv interesting that report does not contains failure, I can find it only in raw logs

I think you are talking about the rerun case. CI report contains latest job rerun.

@maxknv
Copy link
Copy Markdown
Member

maxknv commented Jul 22, 2025

@azat no new tests for bugfix - that's why finish check fails

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pamarcos pamarcos pamarcos approved these changes

Assignees

@pamarcos pamarcos

Labels

🍃 green ci 🌿 Fixing flaky tests in CI pr-bugfix Pull request with bugfix, not backported by default pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Client crash due to disconnected connection after failed INSERT

4 participants

@azat @maxknv @pamarcos @robot-ch-test-poll4