Skip to content

Do not share async_read_counters between queries #83423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
azat merged 1 commit into from
Jul 11, 2025
Merged

Do not share async_read_counters between queries #83423

azat merged 1 commit into from
Jul 11, 2025

Conversation

@azat
Copy link
Member

@azat azat commented Jul 8, 2025 •
edited
Loading

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Do not share async_read_counters between queries

@azat azat requested a review from kssenii July 8, 2025 06:36
@clickhouse-gh
Copy link

clickhouse-gh bot commented Jul 8, 2025 •
edited
Loading

Workflow [PR], commit [e25cd91]

Summary: ❌

job_name test_name status info comment
Integration tests (tsan, 2/6) failure
test_database_delta/test.py::test_timestamp_ntz[0] FAIL
test_database_delta/test.py::test_timestamp_ntz[1] FAIL
Performance Comparison (amd_release, master_head, 2/3) failure
Check Results failure
Finish Workflow failure
python3 ./ci/jobs/scripts/workflow_hooks/new_tests_check.py failure

@clickhouse-gh clickhouse-gh bot added the pr-bugfix Pull request with bugfix, not backported by default label Jul 8, 2025
@kssenii kssenii self-assigned this Jul 8, 2025
Algunenano
Algunenano reviewed Jul 8, 2025
View reviewed changes
@azat azat force-pushed the fix-async_read_counters branch from ede06a1 to e25cd91 Compare July 9, 2025 08:55
@kssenii kssenii assigned Algunenano and unassigned kssenii Jul 10, 2025
@azat
Copy link
Member Author

azat commented Jul 10, 2025 •
edited
Loading

Integration tests (tsan, 2/6) — fail: 2, passed: 594

Performance Comparison (amd_release, master_head, 2/3) — 1 too long, 8 slower, 4 unstable

Should not be related and I hope it is just a conflict of that the binary that is used from upstream contains some performance improvements

Although it is interesting, new results are constantly worse for sum_map

@azat azat enabled auto-merge July 10, 2025 12:02
@azat azat mentioned this pull request Jun 9, 2025
Closed
@azat azat added this pull request to the merge queue Jul 11, 2025
github-merge-queue bot pushed a commit that referenced this pull request Jul 11, 2025
@azat
Merge pull request #83423 from azat/fix-async_read_counters
90c6c2c 
Do not shared async_read_counters between queries
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jul 11, 2025
@azat azat added this pull request to the merge queue Jul 11, 2025
@azat azat changed the title Do not shared async_read_counters between queries Do not share async_read_counters between queries Jul 11, 2025
Merged via the queue into ClickHouse:master with commit 42f073e Jul 11, 2025
117 of 124 checks passed
@azat azat deleted the fix-async_read_counters branch July 11, 2025 08:38
@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-synced-to-cloud The PR is synced to the cloud repo label Jul 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Algunenano Algunenano Algunenano approved these changes

@kssenii kssenii Awaiting requested review from kssenii

Assignees

@Algunenano Algunenano

Labels

pr-bugfix Pull request with bugfix, not backported by default pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@azat @Algunenano @kssenii @robot-ch-test-poll3