Skip to content

Fix crash in client due to connection left in disconnected state after bad INSERT#83253

Merged
azat merged 4 commits intoClickHouse:masterfrom
azat:client-connection-crash
Jul 9, 2025
Merged

Fix crash in client due to connection left in disconnected state after bad INSERT#83253
azat merged 4 commits intoClickHouse:masterfrom
azat:client-connection-crash

Conversation

@azat
Copy link
Copy Markdown
Member

@azat azat commented Jul 4, 2025 •
edited
Loading

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fix crash in client due to connection left in disconnected state after bad INSERT

Fixes: #83123
Fixes: #82933

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Jul 4, 2025 •
edited
Loading

Workflow [PR], commit [cde53ae]

Summary: ❌

job_name test_name status info comment
Build (fuzzers) error
Stress test (arm_asan) failure
Server died FAIL
Hung check failed, possible deadlock found (see hung_check.log) FAIL
Killed by signal (in clickhouse-server.log) FAIL
Fatal message in clickhouse-server.log (see fatal_messages.txt) FAIL
Killed by signal (output files) FAIL

@clickhouse-gh clickhouse-gh bot added the pr-bugfix Pull request with bugfix, not backported by default label Jul 4, 2025
@azat azat mentioned this pull request Jul 4, 2025
Closed
PedroTadim
PedroTadim reviewed Jul 4, 2025
View reviewed changes
@azat azat force-pushed the client-connection-crash branch from 1ad01a9 to 7d78651 Compare July 6, 2025 12:49
tuanpach
tuanpach reviewed Jul 9, 2025
View reviewed changes
@tuanpach tuanpach self-assigned this Jul 9, 2025
@azat
Copy link
Copy Markdown
Member Author

azat commented Jul 9, 2025

Stress test (arm_asan) — Killed by signal (in clickhouse-server.log)

@azat azat enabled auto-merge July 9, 2025 14:19
@azat azat added this pull request to the merge queue Jul 9, 2025
Merged via the queue into ClickHouse:master with commit ec99190 Jul 9, 2025
118 of 122 checks passed
@azat azat deleted the client-connection-crash branch July 9, 2025 14:33
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-synced-to-cloud The PR is synced to the cloud repo label Jul 9, 2025
This was referenced Jul 13, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PedroTadim PedroTadim PedroTadim left review comments

@tuanpach tuanpach tuanpach approved these changes

Assignees

@tuanpach tuanpach

Labels

pr-bugfix Pull request with bugfix, not backported by default pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Client crash due to disconnected connection after failed INSERT 00980_merge_alter_settings is flaky

4 participants

@azat @PedroTadim @tuanpach @robot-ch-test-poll1