Skip to content

Revert "Add SZ3 compression codec"#83076

Merged
tavplubix merged 1 commit intomasterfrom
revert-67161-sz_attempt_2
Jul 2, 2025
Merged

Revert "Add SZ3 compression codec"#83076
tavplubix merged 1 commit intomasterfrom
revert-67161-sz_attempt_2

Conversation

@tavplubix
Copy link
Copy Markdown
Member

@tavplubix tavplubix commented Jul 2, 2025

Reverts #67161

cc: @rschu1ze

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Jul 2, 2025

Workflow [PR], commit [ddddf0c]

@clickhouse-gh clickhouse-gh bot added pr-not-for-changelog This PR should not be mentioned in the changelog submodule changed At least one submodule changed in this PR. labels Jul 2, 2025
@tavplubix tavplubix added this pull request to the merge queue Jul 2, 2025
Merged via the queue into master with commit be3fb8e Jul 2, 2025
19 of 75 checks passed
@tavplubix tavplubix deleted the revert-67161-sz_attempt_2 branch July 2, 2025 14:03
@scanhex12 scanhex12 mentioned this pull request Jul 2, 2025
Merged
@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-synced-to-cloud The PR is synced to the cloud repo label Jul 2, 2025
@divanik
Copy link
Copy Markdown
Member

divanik commented Jul 4, 2025

@tavplubix, could you, please, add a summary of the reason why the PR is reverted next time, because it is unclear for a bystander if looking at this PR?

@rschu1ze
Copy link
Copy Markdown
Member

rschu1ze commented Jul 4, 2025

In most cases, the sync PR of the original PR ran into merge conflicts.

Lots of reviewers (including myself sometimes, unfortunately) only look at the CI overview status but they don't review the sync PR.

@tavplubix
Copy link
Copy Markdown
Member Author

tavplubix commented Jul 4, 2025

could you, please, add a summary of the reason why the PR is reverted next time, because it is unclear for a bystander if looking at this PR?

The reason is always "it has broken the CI", unless another reason is specified. You can check the CI status in the original PR to see what exactly was broken.

Lots of reviewers (including myself sometimes, unfortunately) only look at the CI overview status but they don't review the sync PR.

@rschu1ze, you have manually set the "CH Inc sync" check. So the check was red, and you saw this in the CI overview status. Don't you think it's a good reason to take a look at the sync PR as well?

Screenshot From 2025-07-04 15-05-23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo submodule changed At least one submodule changed in this PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tavplubix @divanik @rschu1ze @robot-ch-test-poll4