Skip to content

Async log: Fix missing thread join#83075

Closed
Algunenano wants to merge 2 commits intoClickHouse:masterfrom
Algunenano:async_log_bug
Closed

Async log: Fix missing thread join#83075
Algunenano wants to merge 2 commits intoClickHouse:masterfrom
Algunenano:async_log_bug

Conversation

@Algunenano
Copy link
Copy Markdown
Member

@Algunenano Algunenano commented Jul 2, 2025

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Async log (unreleased): Fix missing thread join

It also does some minor changes to tests/queries/0_stateless/02116_clickhouse_stderr.sh so it fails in non-default configurations. It was really hard to understand what the test was relying on.

Closes #83063

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Jul 2, 2025 •
edited
Loading

Workflow [PR], commit [8fa210c]

Summary: ❌

job_name test_name status info comment
Integration tests (tsan, 2/6) failure
test_config_decryption/test_wrong_settings_zk.py::test_no_encryption_key_in_zk FAIL
Stress test (amd_debug) failure
Server died FAIL
Hung check failed, possible deadlock found (see hung_check.log) FAIL
Cannot start clickhouse-server FAIL
Server failed to start (see application_errors.txt and clickhouse-server.clean.log) FAIL
Killed by signal (in clickhouse-server.log) FAIL
Fatal message in clickhouse-server.log (see fatal_messages.txt) FAIL
Killed by signal (output files) FAIL
Found signal in gdb.log FAIL
Performance Comparison (amd_release, master_head, 3/3) failure
Check Results failure

@clickhouse-gh clickhouse-gh bot added the pr-not-for-changelog This PR should not be mentioned in the changelog label Jul 2, 2025
@bharatnc bharatnc self-assigned this Jul 2, 2025
@Algunenano Algunenano mentioned this pull request Jul 3, 2025
Closed
@Algunenano
Copy link
Copy Markdown
Member Author

Algunenano commented Jul 3, 2025

Moved to #83121

@Algunenano Algunenano closed this Jul 3, 2025
@Algunenano Algunenano mentioned this pull request Jul 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bharatnc bharatnc bharatnc approved these changes

Assignees

@bharatnc bharatnc

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

WARNING: ThreadSanitizer: thread leak (pid=3824)

2 participants

@Algunenano @bharatnc