Skip to content

Partially revert changes from #81061#83039

Merged
Felixoid merged 3 commits intomasterfrom
docker-library-review
Jul 2, 2025
Merged

Partially revert changes from #81061#83039
Felixoid merged 3 commits intomasterfrom
docker-library-review

Conversation

@Felixoid
Copy link
Copy Markdown
Member

@Felixoid Felixoid commented Jul 1, 2025

During review the changes in docker-library/official-images#19344, the changes appeared to be a wrong move.

Changelog category (leave one):

  • Build/Testing/Packaging Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Change Dockerfile.ubuntu for clickhouse-server to fit requirements in Docker Official Library.

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

@Felixoid
Partially revert changes from #81061
1050193 
During review the changes in docker-library/official-images#19344,
the changes appeared to be a wrong move.
@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Jul 1, 2025 •
edited
Loading

Workflow [PR], commit [e598614]

Summary: ❌

job_name test_name status info comment
Stress test (amd_tsan) failure
Server died FAIL
Hung check failed, possible deadlock found (see hung_check.log) FAIL
Killed by signal (in clickhouse-server.log) FAIL
Fatal message in clickhouse-server.log (see fatal_messages.txt) FAIL
Killed by signal (output files) FAIL
Found signal in gdb.log FAIL
Stress test (amd_ubsan) failure
Killed by signal (in clickhouse-server.log) FAIL
Fatal message in clickhouse-server.log (see fatal_messages.txt) FAIL
Killed by signal (output files) FAIL
Found signal in gdb.log FAIL

@clickhouse-gh clickhouse-gh bot added the pr-build Pull request with build/testing/packaging improvement label Jul 1, 2025
@Algunenano Algunenano self-assigned this Jul 1, 2025
@Felixoid
Copy link
Copy Markdown
Member Author

Felixoid commented Jul 2, 2025

It's implausible that the changes caused the tests' failure.

@Felixoid Felixoid added this pull request to the merge queue Jul 2, 2025
Merged via the queue into master with commit 05dcd2d Jul 2, 2025
118 of 123 checks passed
@Felixoid Felixoid deleted the docker-library-review branch July 2, 2025 12:24
@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-synced-to-cloud The PR is synced to the cloud repo label Jul 2, 2025
@robot-ch-test-poll3 robot-ch-test-poll3 added pr-backports-created-cloud deprecated label, NOOP pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR labels Jul 2, 2025
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 mentioned this pull request Jul 2, 2025
Merged
robot-ch-test-poll1 added a commit that referenced this pull request Jul 2, 2025
@robot-ch-test-poll1
Merge pull request #83073 from ClickHouse/cherrypick/25.6/83039
54ac5e2 
Cherry pick #83039 to 25.6: Partially revert changes from #81061
robot-clickhouse added a commit that referenced this pull request Jul 2, 2025
@robot-clickhouse
Backport #83039 to 25.6: Partially revert changes from #81061
1462a66
@robot-ch-test-poll1 robot-ch-test-poll1 mentioned this pull request Jul 2, 2025
Merged
@robot-ch-test-poll robot-ch-test-poll added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Jul 2, 2025
clickhouse-gh bot added a commit that referenced this pull request Jul 2, 2025
@clickhouse-gh
Merge pull request #83090 from ClickHouse/backport/25.6/83039
a35a604 
Backport #83039 to 25.6: Partially revert changes from #81061
@Felixoid Felixoid mentioned this pull request Jul 4, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Algunenano Algunenano Algunenano approved these changes

Assignees

@Algunenano Algunenano

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud deprecated label, NOOP pr-build Pull request with build/testing/packaging improvement pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR pr-synced-to-cloud The PR is synced to the cloud repo v25.6-must-backport

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Felixoid @Algunenano @robot-ch-test-poll @robot-ch-test-poll4 @robot-ch-test-poll3