Build mutations snapshot using parts visible in query#82945
Merged
Michicosun merged 3 commits intomasterfrom Jul 4, 2025
Merged
Build mutations snapshot using parts visible in query#82945Michicosun merged 3 commits intomasterfrom
Michicosun merged 3 commits intomasterfrom
Conversation
Contributor
clickhouse-gh
bot
added
the
pr-improvement
Michicosun
commented
Jun 30, 2025
| else if (!seen_all_data_mutations) | ||
| { | ||
| if (!status->is_done) | ||
| if (mutation_version > min_part_data_version) |
Member
Author
There was a problem hiding this comment.
main fix is here, mutation can become finished after parts snapshot was taken and in this case it will not be visible during on-fly mutations apply phase.
Michicosun
force-pushed
the
fix_mutations_snapshot
branch
from
7032eae to
2ca05f5
Compare
Michicosun
force-pushed
the
fix_mutations_snapshot
branch
from
2ca05f5 to
664da47
Compare
Michicosun
commented
Jun 30, 2025
| if (!res->hasAnyMutations()) | ||
| return res; | ||
| std::lock_guard lock(currently_processing_in_background_mutex); | ||
| if (!params.need_data_mutations && !params.need_alter_mutations && mutation_counters.num_metadata <= 0) |
Member
Author
There was a problem hiding this comment.
It is probably better completely remove this, because even this check is not 100% accurate, because mutation_counters can be changed between acquisition of a snapshot of parts and mutations. And we can't use approach from rmt because for regular mt mutation entry does not contain alter version
UPD: It is ok to do this way, because mutations will be dropped from the current_mutations_by_version under the same lock
robot-ch-test-poll3
added
the
pr-synced-to-cloud
baibaichen
pushed a commit
to Kyligence/gluten
that referenced
this pull request
Jul 5, 2025
baibaichen
pushed a commit
to apache/gluten
that referenced
this pull request
Jul 6, 2025
* [GLUTEN-1632][CH]Daily Update Clickhouse Version (20250705) * Fix benchmark build * Fix Benchmark build due to ClickHouse/ClickHouse#79417 * Revert "Fix Build due to ClickHouse/ClickHouse#80931" This reverts commit 02d12f6. * Fix Build due to ClickHouse/ClickHouse#81886 * Fix Link issue due to ClickHouse/ClickHouse#83121 * Fix Build due to ClickHouse/ClickHouse#82604 * Fix Build due to ClickHouse/ClickHouse#82945 * Fix Build due to ClickHouse/ClickHouse#83214 --------- Co-authored-by: kyligence-git <[email protected]> Co-authored-by: Chang chen <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Now mutations snapshot will be built from the visible parts snapshot. Also mutation counters used in snapshot will be recalculated from the included mutations