Skip to content

Read AWS ECS token from file, attempt #3#82422

Merged
thevar1able merged 1 commit intomasterfrom
add-expiration-to-eks-tokens
Jun 24, 2025
Merged

Read AWS ECS token from file, attempt #3#82422
thevar1able merged 1 commit intomasterfrom
add-expiration-to-eks-tokens

Conversation

@thevar1able
Copy link
Copy Markdown
Member

@thevar1able thevar1able commented Jun 23, 2025

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Add expiration to AWS ECS token so it can be reloaded.

Relates to #72397

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Jun 23, 2025 •
edited
Loading

Workflow [PR], commit [beffb75]

Summary: ❌

job_name test_name status info comment
Finish Workflow failure
python3 ./ci/jobs/scripts/workflow_hooks/new_tests_check.py failure

@clickhouse-gh clickhouse-gh bot added the pr-bugfix Pull request with bugfix, not backported by default label Jun 23, 2025
thevar1able
thevar1able commented Jun 23, 2025
View reviewed changes
src/IO/S3/Credentials.cpp
}

AddProvider(std::make_shared<Aws::Auth::TaskRoleCredentialsProvider>(absolute_uri.c_str(), token.c_str()));
AddProvider(std::make_shared<Aws::Auth::GeneralHTTPCredentialsProvider>(
Copy link
Copy Markdown
Member Author

@thevar1able thevar1able Jun 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See https://github.com/ClickHouse/aws-sdk-cpp/blob/a86b913abc2795ee23941b24dd51e862214ec6b0/src/aws-cpp-sdk-core/source/auth/AWSCredentialsProviderChain.cpp#L77-L93

@serxa serxa self-assigned this Jun 23, 2025
@thevar1able thevar1able added the pr-must-backport Pull request should be backported intentionally. Use this label with great care! label Jun 23, 2025
@thevar1able thevar1able added this pull request to the merge queue Jun 24, 2025
Merged via the queue into master with commit d3e8c06 Jun 24, 2025
234 of 240 checks passed
@thevar1able thevar1able deleted the add-expiration-to-eks-tokens branch June 24, 2025 17:40
@robot-clickhouse robot-clickhouse added the pr-synced-to-cloud The PR is synced to the cloud repo label Jun 24, 2025
This was referenced Jun 24, 2025
Merged
Merged
robot-ch-test-poll2 added a commit that referenced this pull request Jun 24, 2025
@robot-ch-test-poll2
Merge pull request #82518 from ClickHouse/cherrypick/25.3/82422
7f30889 
Cherry pick #82422 to 25.3: Read AWS ECS token from file, attempt #3
robot-clickhouse added a commit that referenced this pull request Jun 24, 2025
@robot-clickhouse
Backport #82422 to 25.3: Read AWS ECS token from file, attempt #3
5b9a2d5
This was referenced Jun 24, 2025
Merged
Merged
robot-ch-test-poll2 added a commit that referenced this pull request Jun 24, 2025
@robot-ch-test-poll2
Merge pull request #82520 from ClickHouse/cherrypick/25.4/82422
efe0952 
Cherry pick #82422 to 25.4: Read AWS ECS token from file, attempt #3
robot-clickhouse added a commit that referenced this pull request Jun 24, 2025
@robot-clickhouse
Backport #82422 to 25.4: Read AWS ECS token from file, attempt #3
3820f0d
This was referenced Jun 24, 2025
Merged
Merged
robot-ch-test-poll2 added a commit that referenced this pull request Jun 24, 2025
@robot-ch-test-poll2
Merge pull request #82522 from ClickHouse/cherrypick/25.5/82422
2c7c008 
Cherry pick #82422 to 25.5: Read AWS ECS token from file, attempt #3
robot-clickhouse added a commit that referenced this pull request Jun 24, 2025
@robot-clickhouse
Backport #82422 to 25.5: Read AWS ECS token from file, attempt #3
ea3ebeb
This was referenced Jun 24, 2025
Merged
Merged
robot-ch-test-poll2 added a commit that referenced this pull request Jun 24, 2025
@robot-ch-test-poll2
Merge pull request #82524 from ClickHouse/cherrypick/25.6/82422
924810c 
Cherry pick #82422 to 25.6: Read AWS ECS token from file, attempt #3
robot-clickhouse added a commit that referenced this pull request Jun 24, 2025
@robot-clickhouse
Backport #82422 to 25.6: Read AWS ECS token from file, attempt #3
b72ca5f
@robot-ch-test-poll2 robot-ch-test-poll2 mentioned this pull request Jun 24, 2025
Merged
clickhouse-gh bot added a commit that referenced this pull request Jun 24, 2025
@clickhouse-gh
Merge pull request #82525 from ClickHouse/backport/25.6/82422
d8c44b9 
Backport #82422 to 25.6: Read AWS ECS token from file, attempt #3
thevar1able added a commit that referenced this pull request Jun 24, 2025
@thevar1able
Merge pull request #82519 from ClickHouse/backport/25.3/82422
3ea2094 
Backport #82422 to 25.3: Read AWS ECS token from file, attempt #3
thevar1able added a commit that referenced this pull request Jun 24, 2025
@thevar1able
Merge pull request #82521 from ClickHouse/backport/25.4/82422
c980e89 
Backport #82422 to 25.4: Read AWS ECS token from file, attempt #3
thevar1able added a commit that referenced this pull request Jun 24, 2025
@thevar1able
Merge pull request #82523 from ClickHouse/backport/25.5/82422
282d449 
Backport #82422 to 25.5: Read AWS ECS token from file, attempt #3
thevar1able added a commit that referenced this pull request Jun 24, 2025
@thevar1able
Merge pull request #82517 from ClickHouse/cherrypick/24.8/82422
652aeb1 
Cherry pick #82422 to 24.8: Read AWS ECS token from file, attempt #3
robot-clickhouse added a commit that referenced this pull request Jun 24, 2025
@robot-clickhouse
Backport #82422 to 24.8: Read AWS ECS token from file, attempt #3
5187195
@robot-ch-test-poll3 robot-ch-test-poll3 mentioned this pull request Jun 24, 2025
Merged
@robot-clickhouse robot-clickhouse added the pr-backports-created-cloud deprecated label, NOOP label Jun 25, 2025
@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Jun 25, 2025
thevar1able added a commit that referenced this pull request Jun 26, 2025
@thevar1able
Merge pull request #82536 from ClickHouse/backport/24.8/82422
0c6e63c 
Backport #82422 to 24.8: Read AWS ECS token from file, attempt #3
@robot-clickhouse robot-clickhouse added the pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR label Jul 2, 2025
@yokofly yokofly mentioned this pull request Oct 16, 2025
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serxa serxa serxa approved these changes

Assignees

@serxa serxa

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud deprecated label, NOOP pr-bugfix Pull request with bugfix, not backported by default pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@thevar1able @serxa @robot-clickhouse @robot-ch-test-poll2