Fix logical error resolving matcher with multiple JOINs#82421
Merged
Conversation
Contributor
clickhouse-gh
bot
added
the
pr-bugfix
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a logical error in resolving matchers when processing queries with multiple JOINs. The changes include:
- Adding SQL tests to validate JOIN behavior with NULL handling.
- Updating the query analyzer to iterate over all registered table expressions to handle multiple JOIN nodes.
- Updating the reference output to reflect the correct expected results.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/queries/0_stateless/03546_multiple_join_use_nulls_matcher.sql | New test file defining tables, JOIN queries, and cleanup statements to validate the fix. |
| tests/queries/0_stateless/03546_multiple_join_use_nulls_matcher.reference | New reference file with expected output values for the updated SQL tests. |
| src/Analyzer/Resolve/QueryAnalyzer.cpp | Revision to the join resolution logic by iterating over registered table expressions to correctly resolve JOINs. |
serxa
approved these changes
Jun 24, 2025
vdimir
force-pushed
the
vdimir/multiple_join_use_nulls_matcher
branch
from
32f950a to
5152a60
Compare
vdimir
force-pushed
the
vdimir/multiple_join_use_nulls_matcher
branch
from
5152a60 to
f726144
Compare
robot-clickhouse-ci-2
added
the
pr-synced-to-cloud
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Documentation entry for user-facing changes