Conversation
Contributor
clickhouse-gh
bot
added
the
pr-bugfix
CheSema
force-pushed
the
chesema-fix-CGI-params
branch
from
7262a43 to
6a1cc0d
Compare
CheSema
commented
Jun 18, 2025
| output_format_parallel_formatting=1&output_format_parallel_formatting=0 | ||
| output_format_parallel_formatting 0 1 | ||
| output_format_parallel_formatting=0&output_format_parallel_formatting=1 | ||
| output_format_parallel_formatting 0 1 |
Member
Author
There was a problem hiding this comment.
Here is a problem:
URI /?output_format_parallel_formatting=0&output_format_parallel_formatting=1
does not change the value.
This was referenced Jun 18, 2025
Closed
CheSema
changed the title
tuanpach
reviewed
Jun 18, 2025
| /// Other than query parameters are treated as settings. | ||
| if (!customizeQueryParam(context, key, value)) | ||
| settings_changes.push_back({key, value}); | ||
| settings_changes.setSetting(key, value); |
Member
There was a problem hiding this comment.
Should we throw an exception if the key already exists in the setting?
Member
Author
There was a problem hiding this comment.
No, we should not.
We exploit that fact in our tests.
When you do curl "${CLICKHOUSE_URL}&output_format_parallel_formatting=1"
CLICKHOUSE_URL could already has a lot of random settings, you do not know which one.
By adding new one at the end you expect that its last appearance would be taken.
Member
Author
|
Stateless tests (amd_binary, old analyzer, s3 storage, DatabaseReplicated, 2/2) |
tuanpach
approved these changes
Jun 19, 2025
robot-ch-test-poll
added
the
pr-synced-to-cloud
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
when passing settings over URI the last value is considered
Documentation entry for user-facing changes