Rewrite regular expression related functions into simpler and more efficient forms#81992
Merged
alexey-milovidov merged 17 commits intoClickHouse:masterfrom Jul 27, 2025
Merged
Conversation
Contributor
|
Workflow [PR], commit [545162b] Summary: ❌
|
novikd
reviewed
Jun 24, 2025
Member
novikd
left a comment
There was a problem hiding this comment.
PR looks really good, but merging requires some work. Also, it'd be really nice to see any measures of performance improvement.
Collaborator
Author
Sure! I'll try to address the reviews sometime this week. |
Co-authored-by: Dmitry Novik <[email protected]>
Co-authored-by: Dmitry Novik <[email protected]>
Collaborator
Author
|
@novikd All review comments have been addressed and conflicts resolved.
|
Member
|
@novikd, performance improvements are at https://benchmark.clickhouse.com/ |
alexey-milovidov
approved these changes
Jul 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #81981
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Introduced the
optimize_rewrite_regexp_functionssetting (enabled by default), which allows the optimizer to rewrite certainreplaceRegexpAll,replaceRegexpOne, andextractcalls into simpler and more efficient forms when specific regular expression patterns are detected. (issue #81981)Documentation entry for user-facing changes