Fix test_refreshable_mat_view_replicated test_append flakiness#81973
Merged
alexey-milovidov merged 3 commits intomasterfrom Jun 22, 2025
Merged
Fix test_refreshable_mat_view_replicated test_append flakiness#81973alexey-milovidov merged 3 commits intomasterfrom
alexey-milovidov merged 3 commits intomasterfrom
Conversation
Contributor
|
Workflow [PR], commit [7dfbf9e] Summary: ❌
|
fm4v
approved these changes
Jun 16, 2025
evillique
approved these changes
Jun 17, 2025
robot-ch-test-poll2
added
the
pr-synced-to-cloud
robot-ch-test-poll1
added a commit
that referenced
this pull request
Jun 23, 2025
Cherry pick #81973 to 25.6: Fix test_refreshable_mat_view_replicated test_append flakiness
robot-ch-test-poll3
added
the
pr-backports-created
Algunenano
added a commit
that referenced
this pull request
Jun 23, 2025
Backport #81973 to 25.6: Fix test_refreshable_mat_view_replicated test_append flakiness
robot-clickhouse
added
the
pr-must-backport-synced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Closes #81890
The test did
REFRESH EVERY 1 HOURand@pytest.mark.skipif(datetime.now().minute > 57)to make sure the hourly refresh doesn't happen during the test. This turned out to be unreliable becauseskipifis evaluated before running a group of tests, which may take longer than 3 minutes before this test starts. This PR doesEVERY 1 HOUR OFFSET {opposite_minutes} MINUTEinstead, so the first refresh is always scheduled 30 minutes after RMV is created.