Closed
Conversation
1 task
Contributor
|
Workflow [PR], commit [db1d587] Summary: ❌
|
rschu1ze
reviewed
Jun 26, 2025
| @@ -0,0 +1,125 @@ | |||
| # Index Advisor ⚠️ Experimental | |||
| { | ||
| } | ||
|
|
||
| IndexTypes getBestMinMaxIndexForTable(const String & table); |
alexey-milovidov
added
the
close in a month if not active
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Add support for Index advisor. This structure recommends indexes and primary keys for collected workload (special START/FINISH COLLECTING WORKLOAD keywords)
Documentation entry for user-facing changes
Description of code
All queries executed after
START COLLECTING WORKLOADare written into file. WhenFINISH COLLECTING WORKLOADis called, all queries will be read by algorithm. For each query it determines kind of query (we need to optimise select queries, but some queries may depend on views that were created and removed in workload, so we store them too). All columns, that are used in queries are collected and matched with tables. Then we execute search for pk or skip index. Algorithms are described fully in docs (just extract number of read marks using EXPLAIN ESTIMATE for each query). Finally, results are shown to user as a table.