Skip to content

Fix crash in ConcurrentHashJoin with empty USING ()#81754

Merged
nikitamikhaylov merged 3 commits intomasterfrom
parallel_hash_empty_using
Jun 13, 2025
Merged

Fix crash in ConcurrentHashJoin with empty USING ()#81754
nikitamikhaylov merged 3 commits intomasterfrom
parallel_hash_empty_using

Conversation

@nickitat
Copy link
Copy Markdown
Member

@nickitat nickitat commented Jun 12, 2025

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fix crash in ConcurrentHashJoin with empty USING () and old analyzer enabled.

Closes: #81540

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Jun 12, 2025 •
edited
Loading

Workflow [PR], commit [4af10ea]

@clickhouse-gh clickhouse-gh bot added the pr-bugfix Pull request with bugfix, not backported by default label Jun 12, 2025
@nickitat nickitat added pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-cloud labels Jun 12, 2025
@KochetovNicolai KochetovNicolai self-requested a review June 12, 2025 19:13
@novikd novikd self-assigned this Jun 13, 2025
@nikitamikhaylov nikitamikhaylov added this pull request to the merge queue Jun 13, 2025
Merged via the queue into master with commit 95f2e9b Jun 13, 2025
235 of 236 checks passed
@nikitamikhaylov nikitamikhaylov deleted the parallel_hash_empty_using branch June 13, 2025 23:32
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-synced-to-cloud The PR is synced to the cloud repo label Jun 13, 2025
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 mentioned this pull request Jun 14, 2025
Merged
robot-clickhouse-ci-2 added a commit that referenced this pull request Jun 14, 2025
@robot-clickhouse-ci-2
Merge pull request #81841 from ClickHouse/cherrypick/24.8/81754
a1dbf3c 
Cherry pick #81754 to 24.8: Fix crash in `ConcurrentHashJoin` with empty `USING ()`
robot-clickhouse added a commit that referenced this pull request Jun 14, 2025
@robot-clickhouse
Backport #81754 to 24.8: Fix crash in ConcurrentHashJoin with empty…
de3e1bd 
… `USING ()`
This was referenced Jun 14, 2025
Closed
Merged
robot-clickhouse-ci-2 added a commit that referenced this pull request Jun 14, 2025
@robot-clickhouse-ci-2
Merge pull request #81843 from ClickHouse/cherrypick/25.3/81754
d84bd6c 
Cherry pick #81754 to 25.3: Fix crash in `ConcurrentHashJoin` with empty `USING ()`
robot-clickhouse added a commit that referenced this pull request Jun 14, 2025
@robot-clickhouse
Backport #81754 to 25.3: Fix crash in ConcurrentHashJoin with empty…
5fce007 
… `USING ()`
This was referenced Jun 14, 2025
Merged
Merged
robot-clickhouse-ci-2 added a commit that referenced this pull request Jun 14, 2025
@robot-clickhouse-ci-2
Merge pull request #81845 from ClickHouse/cherrypick/25.4/81754
f98f55f 
Cherry pick #81754 to 25.4: Fix crash in `ConcurrentHashJoin` with empty `USING ()`
robot-clickhouse added a commit that referenced this pull request Jun 14, 2025
@robot-clickhouse
Backport #81754 to 25.4: Fix crash in ConcurrentHashJoin with empty…
97a831f 
… `USING ()`
This was referenced Jun 14, 2025
Merged
Merged
robot-clickhouse-ci-2 added a commit that referenced this pull request Jun 14, 2025
@robot-clickhouse-ci-2
Merge pull request #81847 from ClickHouse/cherrypick/25.5/81754
cc54bb2 
Cherry pick #81754 to 25.5: Fix crash in `ConcurrentHashJoin` with empty `USING ()`
robot-clickhouse added a commit that referenced this pull request Jun 14, 2025
@robot-clickhouse
Backport #81754 to 25.5: Fix crash in ConcurrentHashJoin with empty…
e3d3721 
… `USING ()`
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 mentioned this pull request Jun 14, 2025
Merged
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-backports-created-cloud deprecated label, NOOP label Jun 14, 2025
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Jun 14, 2025
alexey-milovidov added a commit that referenced this pull request Jun 14, 2025
@alexey-milovidov
Merge pull request #81846 from ClickHouse/backport/25.4/81754
ee2a357 
Backport #81754 to 25.4: Fix crash in `ConcurrentHashJoin` with empty `USING ()`
nickitat added a commit that referenced this pull request Jun 16, 2025
@nickitat
Merge pull request #81844 from ClickHouse/backport/25.3/81754
662faff 
Backport #81754 to 25.3: Fix crash in `ConcurrentHashJoin` with empty `USING ()`
nickitat added a commit that referenced this pull request Jun 16, 2025
@nickitat
Merge pull request #81848 from ClickHouse/backport/25.5/81754
1ee1026 
Backport #81754 to 25.5: Fix crash in `ConcurrentHashJoin` with empty `USING ()`
baibaichen pushed a commit to Kyligence/ClickHouse that referenced this pull request Jun 20, 2025
Revert "Merge pull request ClickHouse#81754 from ClickHouse/parallel_…
3a0c91e 
…hash_empty_using"

This reverts commit 95f2e9b, reversing
changes made to b908c75.
baibaichen pushed a commit to Kyligence/ClickHouse that referenced this pull request Jun 21, 2025
[TMP] Partially revert "Merge pull request ClickHouse#81754 from Clic…
8960b38 
…kHouse/parallel_hash_empty_using"

This reverts commit 95f2e9b, reversing
changes made to b908c75.
baibaichen pushed a commit to Kyligence/gluten that referenced this pull request Jun 21, 2025
[TMP] Partially revert "Merge pull request #81754 from ClickHouse/par…
e5ae726 
…allel_hash_empty_using"

Due to ClickHouse/ClickHouse#81754
baibaichen pushed a commit to apache/gluten that referenced this pull request Jun 21, 2025
@kyligence-git
[GLUTEN-1632][CH]Daily Update Clickhouse Version (20250621) (#10024)
7f809f1 
* [GLUTEN-1632][CH]Daily Update Clickhouse Version (20250621)

* Fix Build due to ClickHouse/ClickHouse#82194

* [TMP] Partially revert "Merge pull request #81754 from ClickHouse/parallel_hash_empty_using"

Due to ClickHouse/ClickHouse#81754

---------

Co-authored-by: kyligence-git <[email protected]>
Co-authored-by: Chang chen <[email protected]>
kyligence-git pushed a commit to Kyligence/ClickHouse that referenced this pull request Jun 21, 2025
[TMP] Partially revert "Merge pull request ClickHouse#81754 from Clic…
5e8d8ef 
…kHouse/parallel_hash_empty_using"

This reverts commit 95f2e9b, reversing
changes made to b908c75.
kyligence-git pushed a commit to Kyligence/ClickHouse that referenced this pull request Jun 22, 2025
[TMP] Partially revert "Merge pull request ClickHouse#81754 from Clic…
8bce8b8 
…kHouse/parallel_hash_empty_using"

This reverts commit 95f2e9b, reversing
changes made to b908c75.
@rienath rienath mentioned this pull request Jun 23, 2025
Closed
kyligence-git pushed a commit to Kyligence/ClickHouse that referenced this pull request Jun 23, 2025
[TMP] Partially revert "Merge pull request ClickHouse#81754 from Clic…
5a8e048 
…kHouse/parallel_hash_empty_using"

This reverts commit 95f2e9b, reversing
changes made to b908c75.
kyligence-git pushed a commit to Kyligence/ClickHouse that referenced this pull request Jun 24, 2025
[TMP] Partially revert "Merge pull request ClickHouse#81754 from Clic…
2460113 
…kHouse/parallel_hash_empty_using"

This reverts commit 95f2e9b, reversing
changes made to b908c75.
baibaichen pushed a commit to Kyligence/ClickHouse that referenced this pull request Jun 26, 2025
[TMP] Partially revert "Merge pull request ClickHouse#81754 from Clic…
c9fa204 
…kHouse/parallel_hash_empty_using"

This reverts commit 95f2e9b, reversing
changes made to b908c75.
baibaichen pushed a commit to Kyligence/gluten that referenced this pull request Jun 27, 2025
Try Fixed issued casued by ClickHouse/ClickHouse#81754
372396d 
see ClickHouse/ClickHouse#82379
baibaichen pushed a commit to Kyligence/gluten that referenced this pull request Jun 27, 2025
Try to Fix issue caused by ClickHouse/ClickHouse#81754
2564f78 
see ClickHouse/ClickHouse#82379
baibaichen pushed a commit to Kyligence/gluten that referenced this pull request Jun 28, 2025
Try to Fix issue caused by ClickHouse/ClickHouse#81754
a1c8e91 
see ClickHouse/ClickHouse#82379
baibaichen pushed a commit to Kyligence/gluten that referenced this pull request Jun 29, 2025
Try to Fix issue caused by ClickHouse/ClickHouse#81754
ae1ce2d 
see ClickHouse/ClickHouse#82379
baibaichen pushed a commit to apache/gluten that referenced this pull request Jun 29, 2025
@kyligence-git
[GLUTEN-1632][CH]Daily Update Clickhouse Version (20250629) (#10080)
748a272 
* [GLUTEN-1632][CH]Daily Update Clickhouse Version (20250629)

* Fix Build due to ClickHouse/ClickHouse#80931

* Fix Build due to ClickHouse/ClickHouse#81976

* Fix Build due to  ClickHouse/ClickHouse#82508

* Try to Fix issue caused by ClickHouse/ClickHouse#81754

see ClickHouse/ClickHouse#82379

* Fix UT due to ClickHouse/ClickHouse#82358

---------

Co-authored-by: kyligence-git <[email protected]>
Co-authored-by: Chang chen <[email protected]>
@robot-clickhouse robot-clickhouse added the pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR label Jul 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KochetovNicolai KochetovNicolai KochetovNicolai approved these changes

@novikd novikd novikd approved these changes

Assignees

@novikd novikd

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud deprecated label, NOOP pr-bugfix Pull request with bugfix, not backported by default pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

"Address not mapped to object" in 25.4.5.24

8 participants

@nickitat @KochetovNicolai @novikd @nikitamikhaylov @robot-clickhouse @robot-ch-test-poll1 @robot-clickhouse-ci-1 @robot-clickhouse-ci-2