Support compressed metadata in Iceberg#81451
Merged
Conversation
Contributor
clickhouse-gh
bot
added
the
pr-improvement
Contributor
alesapin
commented
Jun 18, 2025
|
|
||
| auto pos = data_path.find(common_path); | ||
| /// Valid situation when data and metadata files are stored in different directories. | ||
| if (pos == std::string::npos) |
Member
Author
There was a problem hiding this comment.
This change is unrelated, but there are some implementations of iceberg which store data and metadata in different directories.
kssenii
reviewed
Jun 18, 2025
| struct ShortMetadataFileInfo | ||
| { | ||
| UInt32 version; | ||
| Int32 version; |
Member
Author
There was a problem hiding this comment.
All these metadata come from Java world. There are no unsigned integers in java. So I think actually answer is "no", but technically "yes"
kssenii
approved these changes
Jun 18, 2025
robot-ch-test-poll4
added
the
pr-synced-to-cloud
Merged
1 task
This was referenced Sep 9, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Now clickhouse supports compressed
metadata.jsonfiles for Iceberg. Fixes #70874.Documentation entry for user-facing changes