Improve lifetime management of projection part during query#81191
Merged
kssenii merged 3 commits intoClickHouse:masterfrom Jun 9, 2025
Merged
Improve lifetime management of projection part during query#81191kssenii merged 3 commits intoClickHouse:masterfrom
kssenii merged 3 commits intoClickHouse:masterfrom
Conversation
amosbird
commented
Jun 3, 2025
| data_part->getParentPartName(), data_part->getDataPartStorage().getFullPath()); | ||
| } | ||
|
|
||
| read_task_info.parent_part = part_with_ranges.parent_part; |
Collaborator
Author
There was a problem hiding this comment.
Here is the improvement.
Contributor
clickhouse-gh
bot
added
the
pr-not-for-changelog
amosbird
force-pushed
the
improve-projection-part-lifetime
branch
from
84969b4 to
9459598
Compare
Collaborator
Author
|
kssenii
reviewed
Jun 6, 2025
Member
|
@amosbird please also check build failure, I guess you need to fetch recent changes from master |
amosbird
force-pushed
the
improve-projection-part-lifetime
branch
from
7fe3a0d to
cc33163
Compare
kssenii
approved these changes
Jun 6, 2025
Member
test_storage_kafka |
Merged
via the queue into
ClickHouse:master
with commit Jun 9, 2025
939f2fe
118 of 121 checks passed
robot-ch-test-poll1
added
the
pr-synced-to-cloud
baibaichen
pushed a commit
to Kyligence/gluten
that referenced
this pull request
Jun 10, 2025
baibaichen
pushed a commit
to Kyligence/gluten
that referenced
this pull request
Jun 11, 2025
baibaichen
pushed a commit
to apache/gluten
that referenced
this pull request
Jun 11, 2025
* [GLUTEN-1632][CH]Daily Update Clickhouse Version (20250611) * Fix Build due to ClickHouse/ClickHouse#81191 * Fix UT due to ClickHouse/ClickHouse#79471 --------- Co-authored-by: kyligence-git <[email protected]> Co-authored-by: Chang chen <[email protected]>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
The previous fix #63513 relied on excessive part locking during query planning, which impacted performance. After the recent refactoring PR #79417, the lifetime management can now be improved with a much simpler and more efficient approach.
Documentation entry for user-facing changes