Skip to content

Backport #80913 to 24.8: fix hasEqualValues for nullable columns#81055

Merged
GrigoryPervakov merged 1 commit into24.8from
backport/24.8/80913
May 30, 2025
Merged

Backport #80913 to 24.8: fix hasEqualValues for nullable columns#81055
GrigoryPervakov merged 1 commit into24.8from
backport/24.8/80913

Conversation

@robot-clickhouse-ci-2
Copy link
Copy Markdown
Contributor

@robot-clickhouse-ci-2 robot-clickhouse-ci-2 commented May 30, 2025

Original pull-request #80913
Cherry-pick pull-request #81054

This pull-request is a last step of an automated backporting.
Treat it as a standard pull-request: look at the checks and resolve conflicts.
Merge it only if you intend to backport changes to the target branch, otherwise just close it.

The PR source

The PR is created in the CI job

@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added pr-backport Changes, backported to release branch. Do not use manually - automated use only! pr-bugfix Pull request with bugfix, not backported by default labels May 30, 2025
@robot-ch-test-poll1
Copy link
Copy Markdown
Contributor

robot-ch-test-poll1 commented May 30, 2025 •
edited by robot-ch-test-poll4
Loading

This is an automated comment for commit b2b2015 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests❌ failure
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Successful checks
Check nameDescriptionStatus
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success

@GrigoryPervakov GrigoryPervakov merged commit b0782cb into 24.8 May 30, 2025
43 of 60 checks passed
@GrigoryPervakov GrigoryPervakov deleted the backport/24.8/80913 branch May 30, 2025 17:41
@Algunenano
Copy link
Copy Markdown
Member

Algunenano commented Jun 3, 2025

The test added is failing, even in this PR: https://s3.amazonaws.com/clickhouse-test-reports/81055/b2b2015d6f13f85e5976f27af93bebcc02a64286/stateless_tests__asan__[2_2].html

@GrigoryPervakov please check the CI before merging, and please fix the test for this version

@GrigoryPervakov
Copy link
Copy Markdown
Member

GrigoryPervakov commented Jun 4, 2025

@Algunenano I made a fix here #81292

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@GrigoryPervakov GrigoryPervakov

@Avogar Avogar

Labels

pr-backport Changes, backported to release branch. Do not use manually - automated use only! pr-bugfix Pull request with bugfix, not backported by default

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@robot-clickhouse-ci-2 @robot-ch-test-poll1 @Algunenano @GrigoryPervakov @Avogar @robot-clickhouse