Fix atomic rename with truncate for files which compression is inferred from their file extension#80979
Merged
alexey-milovidov merged 1 commit intomasterfrom May 29, 2025
Merged
Conversation
It was taking the original name from the temp file name, which was built with a custom suffix. Due to this suffix, if the original file had any compression extension, ClickHouse didn't automatically detect and apply the one to use.
Contributor
clickhouse-gh
bot
added
the
pr-bugfix
1 task
alexey-milovidov
added
the
pr-must-backport
alexey-milovidov
approved these changes
May 28, 2025
This was referenced May 29, 2025
robot-ch-test-poll3
added a commit
that referenced
this pull request
May 29, 2025
Cherry pick #80979 to 25.3: Fix atomic rename with truncate for files which compression is inferred from their file extension
robot-clickhouse
added a commit
that referenced
this pull request
May 29, 2025
…ich compression is inferred from their file extension
This was referenced May 29, 2025
robot-ch-test-poll3
added a commit
that referenced
this pull request
May 29, 2025
Cherry pick #80979 to 25.4: Fix atomic rename with truncate for files which compression is inferred from their file extension
robot-clickhouse
added a commit
that referenced
this pull request
May 29, 2025
…ich compression is inferred from their file extension
This was referenced May 29, 2025
robot-ch-test-poll3
added a commit
that referenced
this pull request
May 29, 2025
Cherry pick #80979 to 25.5: Fix atomic rename with truncate for files which compression is inferred from their file extension
robot-clickhouse
added a commit
that referenced
this pull request
May 29, 2025
…ich compression is inferred from their file extension
robot-ch-test-poll1
added
the
pr-synced-to-cloud
pamarcos
added a commit
that referenced
this pull request
May 29, 2025
Backport #80979 to 25.5: Fix atomic rename with truncate for files which compression is inferred from their file extension
pamarcos
added a commit
that referenced
this pull request
May 29, 2025
Backport #80979 to 25.4: Fix atomic rename with truncate for files which compression is inferred from their file extension
pamarcos
added a commit
that referenced
this pull request
May 29, 2025
Backport #80979 to 25.3: Fix atomic rename with truncate for files which compression is inferred from their file extension
robot-clickhouse-ci-2
added
the
pr-backports-created-cloud
robot-clickhouse-ci-1
added
the
pr-backports-created
robot-clickhouse
added
the
pr-must-backport-synced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This comment raised there was an error on the implementation.
The problem is that it was taking the original name from the temp file name, which was built with a custom suffix. Due to this suffix, if the original file had any compression extension, ClickHouse didn't automatically detect and apply the one to use.
Interestingly, the stateless test did check that it was working with compression, but it was setting explicitly the compression to use.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix atomic rename with truncate for files which compression is inferred from their file extension
Documentation entry for user-facing changes