fix hasEqualValues for nullable columns#80913
Merged
GrigoryPervakov merged 1 commit intomasterfrom May 30, 2025
Merged
Conversation
Contributor
clickhouse-gh
bot
added
the
pr-bugfix
Avogar
approved these changes
May 27, 2025
GrigoryPervakov
force-pushed
the
nullable-sharding
branch
2 times, most recently
from
c0554ad to
fe1e03c
Compare
Member
|
Just a comment. Don't forget some of the bug fixes may be worth backporting? |
GrigoryPervakov
added
the
pr-must-backport
GrigoryPervakov
force-pushed
the
nullable-sharding
branch
from
fe1e03c to
8c0d931
Compare
Member
Author
robot-ch-test-poll3
added
the
pr-synced-to-cloud
robot-clickhouse-ci-2
added a commit
that referenced
this pull request
May 30, 2025
Cherry pick #80913 to 24.8: fix hasEqualValues for nullable columns
robot-clickhouse
added a commit
that referenced
this pull request
May 30, 2025
This was referenced May 30, 2025
robot-clickhouse-ci-2
added a commit
that referenced
this pull request
May 30, 2025
Cherry pick #80913 to 25.3: fix hasEqualValues for nullable columns
robot-clickhouse
added a commit
that referenced
this pull request
May 30, 2025
This was referenced May 30, 2025
robot-clickhouse-ci-2
added a commit
that referenced
this pull request
May 30, 2025
Cherry pick #80913 to 25.4: fix hasEqualValues for nullable columns
robot-clickhouse
added a commit
that referenced
this pull request
May 30, 2025
This was referenced May 30, 2025
robot-clickhouse-ci-2
added a commit
that referenced
this pull request
May 30, 2025
Cherry pick #80913 to 25.5: fix hasEqualValues for nullable columns
robot-clickhouse
added a commit
that referenced
this pull request
May 30, 2025
robot-clickhouse-ci-2
added
the
pr-backports-created
GrigoryPervakov
added a commit
that referenced
this pull request
May 30, 2025
Backport #80913 to 25.5: fix hasEqualValues for nullable columns
GrigoryPervakov
added a commit
that referenced
this pull request
May 30, 2025
Backport #80913 to 25.4: fix hasEqualValues for nullable columns
GrigoryPervakov
added a commit
that referenced
this pull request
May 30, 2025
Backport #80913 to 25.3: fix hasEqualValues for nullable columns
GrigoryPervakov
added a commit
that referenced
this pull request
May 30, 2025
Backport #80913 to 24.8: fix hasEqualValues for nullable columns
robot-clickhouse
added
the
pr-must-backport-synced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For nullable columns, hasEqualValues returns true if the first value is null.
It leads to errors during data partitioning in cases like
VALUES (NULL), (1), (2), (3), so all values go to the single partitionhttps://fiddle.clickhouse.com/88ed6ef0-30e7-4b69-922e-2bcccb36acf4
Closes #74072
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix wrong partitioning with nullable partition key