Make 02790_async_queries_in_query_log stable#80851
Merged
Algunenano merged 1 commit intoClickHouse:masterfrom May 27, 2025
Merged
Make 02790_async_queries_in_query_log stable#80851Algunenano merged 1 commit intoClickHouse:masterfrom
Algunenano merged 1 commit intoClickHouse:masterfrom
Conversation
Contributor
clickhouse-gh
bot
added
the
pr-not-for-changelog
CheSema
approved these changes
May 26, 2025
robot-clickhouse-ci-2
added a commit
that referenced
this pull request
May 27, 2025
Cherry pick #80851 to 25.5: Make 02790_async_queries_in_query_log stable
robot-clickhouse
added a commit
that referenced
this pull request
May 27, 2025
robot-ch-test-poll1
added
pr-synced-to-cloud
Algunenano
added a commit
that referenced
this pull request
May 27, 2025
Backport #80851 to 25.5: Make 02790_async_queries_in_query_log stable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Make 02790_async_queries_in_query_log stable
Apparently there were some hacks before that made us ignore errors in some corner cases (like the first MV) and materialized_views_ignore_errors was not working fully as expected. #77309 fixed that and now things work as expected, which also means that the only way to guarantee the data will land in the landing for sure is to use materialized_views_ignore_errors=1. If you don't use the setting, then data might or might not land which made the test flaky.
Closes #80813
Documentation entry for user-facing changes