Skip to content

Fix crash in Kafka due to get_member_id() was creating std::string from NULL#80793

Merged
azat merged 1 commit intoClickHouse:masterfrom
azat:cppkafka-member_id-fix
May 27, 2025
Merged

Fix crash in Kafka due to get_member_id() was creating std::string from NULL#80793
azat merged 1 commit intoClickHouse:masterfrom
azat:cppkafka-member_id-fix

Conversation

@azat
Copy link
Copy Markdown
Member

@azat azat commented May 25, 2025

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fix crash in Kafka due to get_member_id() was creating std::string from NULL (it was likely an issue only in case of connection to broker had been failed)

Fixes: #80674
Refs: ClickHouse/cppkafka#4
Fixes: #58310

…om NULL

It was likely an issue when the connection to broker had been failed.

Refs: ClickHouse#80674
Refs: ClickHouse/cppkafka#4
@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented May 25, 2025

Workflow [PR], commit [76e3525]

@clickhouse-gh clickhouse-gh bot added pr-bugfix Pull request with bugfix, not backported by default submodule changed At least one submodule changed in this PR. labels May 25, 2025
@azat azat added the pr-must-backport Pull request should be backported intentionally. Use this label with great care! label May 25, 2025
@azat
Copy link
Copy Markdown
Member Author

azat commented May 27, 2025

CI failures unrelated (fixed in #80386)

@azat azat enabled auto-merge May 27, 2025 06:38
@azat azat added this pull request to the merge queue May 27, 2025
Merged via the queue into ClickHouse:master with commit a222bfd May 27, 2025
109 of 130 checks passed
@azat azat deleted the cppkafka-member_id-fix branch May 27, 2025 06:54
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-synced-to-cloud The PR is synced to the cloud repo label May 27, 2025
robot-ch-test-poll3 added a commit that referenced this pull request May 27, 2025
Cherry pick #80793 to 25.4: Fix crash in Kafka due to get_member_id() was creating std::string from NULL
robot-clickhouse added a commit that referenced this pull request May 27, 2025
robot-ch-test-poll3 added a commit that referenced this pull request May 27, 2025
Cherry pick #80793 to 25.5: Fix crash in Kafka due to get_member_id() was creating std::string from NULL
robot-clickhouse added a commit that referenced this pull request May 27, 2025
azat added a commit that referenced this pull request May 28, 2025
Backport #80793 to 25.5: Fix crash in Kafka due to get_member_id() was creating std::string from NULL
azat added a commit that referenced this pull request Jun 1, 2025
Backport #80793 to 25.4: Fix crash in Kafka due to get_member_id() was creating std::string from NULL
robot-clickhouse-ci-1 added a commit that referenced this pull request Jun 1, 2025
Cherry pick #80793 to 25.3: Fix crash in Kafka due to get_member_id() was creating std::string from NULL
robot-clickhouse added a commit that referenced this pull request Jun 1, 2025
@robot-ch-test-poll robot-ch-test-poll added the pr-backports-created-cloud deprecated label, NOOP label Jun 1, 2025
@robot-clickhouse robot-clickhouse added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Jun 1, 2025
azat added a commit that referenced this pull request Jun 1, 2025
Backport #80793 to 25.3: Fix crash in Kafka due to get_member_id() was creating std::string from NULL
@robot-clickhouse robot-clickhouse added the pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR label Jul 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud deprecated label, NOOP pr-bugfix Pull request with bugfix, not backported by default pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR pr-synced-to-cloud The PR is synced to the cloud repo submodule changed At least one submodule changed in this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Segfault on attempt to create engine=Kafka table without group name

5 participants