Fix crash in Kafka due to get_member_id() was creating std::string from NULL#80793
Merged
azat merged 1 commit intoClickHouse:masterfrom May 27, 2025
Merged
Fix crash in Kafka due to get_member_id() was creating std::string from NULL#80793azat merged 1 commit intoClickHouse:masterfrom
azat merged 1 commit intoClickHouse:masterfrom
Conversation
…om NULL It was likely an issue when the connection to broker had been failed. Refs: ClickHouse#80674 Refs: ClickHouse/cppkafka#4
Contributor
This was referenced May 25, 2025
tuanpach
approved these changes
May 27, 2025
Member
Author
|
CI failures unrelated (fixed in #80386) |
Merged
via the queue into
ClickHouse:master
with commit May 27, 2025
a222bfd
109 of 130 checks passed
This was referenced May 27, 2025
robot-ch-test-poll3
added a commit
that referenced
this pull request
May 27, 2025
Cherry pick #80793 to 25.4: Fix crash in Kafka due to get_member_id() was creating std::string from NULL
robot-clickhouse
added a commit
that referenced
this pull request
May 27, 2025
…s creating std::string from NULL
robot-ch-test-poll3
added a commit
that referenced
this pull request
May 27, 2025
Cherry pick #80793 to 25.5: Fix crash in Kafka due to get_member_id() was creating std::string from NULL
robot-clickhouse
added a commit
that referenced
this pull request
May 27, 2025
…s creating std::string from NULL
azat
added a commit
that referenced
this pull request
May 28, 2025
Backport #80793 to 25.5: Fix crash in Kafka due to get_member_id() was creating std::string from NULL
azat
added a commit
that referenced
this pull request
Jun 1, 2025
Backport #80793 to 25.4: Fix crash in Kafka due to get_member_id() was creating std::string from NULL
robot-clickhouse-ci-1
added a commit
that referenced
this pull request
Jun 1, 2025
Cherry pick #80793 to 25.3: Fix crash in Kafka due to get_member_id() was creating std::string from NULL
robot-clickhouse
added a commit
that referenced
this pull request
Jun 1, 2025
…s creating std::string from NULL
azat
added a commit
that referenced
this pull request
Jun 1, 2025
Backport #80793 to 25.3: Fix crash in Kafka due to get_member_id() was creating std::string from NULL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix crash in Kafka due to get_member_id() was creating std::string from NULL (it was likely an issue only in case of connection to broker had been failed)
Fixes: #80674
Refs: ClickHouse/cppkafka#4
Fixes: #58310