Fix settings + add experimental flag for Time/Time64 #80640
Conversation
clickhouse-gh
bot
added
the
pr-not-for-changelog
pamarcos
left a comment
pamarcos
left a comment
There was a problem hiding this comment.
@yariks5s help me here to understand why these changes are needed now, since the description of the PR is completely empty. I guess it comes from #75735 (comment), where we decide this should be under an experimental flag, right?
This seems to me quite a compatibility breaking change. However, it's not even listed in the changelog. I'm lost, to be honest 😅
| )", IMPORTANT) \ | ||
| DECLARE(Bool, allow_experimental_time_time64_type, false, R"( | ||
| Allows creation of [Time](../../sql-reference/data-types/time.md) and [Time64](../../sql-reference/data-types/time64.md) data types. | ||
| )", EXPERIMENTAL, enable_time_time64_type) \ |
There was a problem hiding this comment.
It's not marked as IMPORTANT as per #75735 (comment)
Auto-answering myself: since the changes introduced in #75735 have not been released yet (will be in the next 25.5), it's ok to do this change now |
|
Closing on behalf of #80700 |
Follow-up #75735
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
...
Documentation entry for user-facing changes