Skip to content

storage url does not call server on empty data#80591

Merged
CheSema merged 4 commits intomasterfrom
chesema-storage-url-test
May 21, 2025
Merged

storage url does not call server on empty data#80591
CheSema merged 4 commits intomasterfrom
chesema-storage-url-test

Conversation

@CheSema
Copy link
Copy Markdown
Member

@CheSema CheSema commented May 20, 2025 •
edited
Loading

Closes #78747

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

test that storage url does not call server on empty data

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented May 20, 2025 •
edited
Loading

Workflow [PR], commit [a2b533b]

@CheSema CheSema changed the title Chesema storage url test storage url does not call server on empty data May 20, 2025
@clickhouse-gh clickhouse-gh bot added the pr-not-for-changelog This PR should not be mentioned in the changelog label May 20, 2025
@Avogar Avogar self-assigned this May 20, 2025
@CheSema
Copy link
Copy Markdown
Member Author

CheSema commented May 21, 2025

Stateless tests (debug, AsyncInsert, s3 storage)
I need to fix it.

@CheSema
Copy link
Copy Markdown
Member Author

CheSema commented May 21, 2025

02962_system_sync_replica_lightweight_from_modifier - flaky #60480

@CheSema CheSema added this pull request to the merge queue May 21, 2025
Merged via the queue into master with commit b3cd54a May 21, 2025
118 of 121 checks passed
@CheSema CheSema deleted the chesema-storage-url-test branch May 21, 2025 18:26
@robot-clickhouse robot-clickhouse added the pr-synced-to-cloud The PR is synced to the cloud repo label May 21, 2025
@azat
Copy link
Copy Markdown
Member

azat commented May 22, 2025

@CheSema new test is flaky, here is an example - https://s3.amazonaws.com/clickhouse-test-reports/json.html?PR=80680&sha=b11abdbb68ad684af32e8f54a718dc04e42cb17e&name_0=PR&name_1=Stateless%20tests%20%28tsan%2C%203%2F3%29

@CheSema
Copy link
Copy Markdown
Member Author

CheSema commented May 22, 2025

Sema Checherinda new test is flaky, here is an example - https://s3.amazonaws.com/clickhouse-test-reports/json.html?PR=80680&sha=b11abdbb68ad684af32e8f54a718dc04e42cb17e&name_0=PR&name_1=Stateless%20tests%20%28tsan%2C%203%2F3%29

I really do not see what could be wrong with that failture
So, may be it is ok to add more info in such error:
#80709

@amosbird
Copy link
Copy Markdown
Collaborator

amosbird commented May 23, 2025

https://s3.amazonaws.com/clickhouse-test-reports/json.html?PR=79471&sha=4cd0f8e0282b50a35842e6727b0bc803421d8217&name_0=PR&name_1=Stateless%20tests%20%28coverage%2C%206%2F6%29

@amosbird amosbird mentioned this pull request May 23, 2025
Merged
1 task
@CheSema CheSema mentioned this pull request May 23, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Avogar Avogar Avogar approved these changes

Assignees

@Avogar Avogar

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Materialise view seems to be triggered with empty insert even when no new data matches WHERE clause

5 participants

@CheSema @azat @amosbird @Avogar @robot-clickhouse